You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/04/22 15:45:48 UTC
[GitHub] [incubator-doris] morningman commented on a change in pull request #5555: [Colocate plan][Step2] Colocate aggregation covers more situations
morningman commented on a change in pull request #5555:
URL: https://github.com/apache/incubator-doris/pull/5555#discussion_r618484554
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -974,6 +984,64 @@ private PlanFragment createAggregationFragment(
}
}
+ /**
+ * Colocate Agg can be performed when the following 2 conditions are met at the same time.
+ * 1. Session variables disable_colocate_plan = true
+ * 2. The input data partition of child fragment < agg node partition exprs
+ */
+ private boolean canColocateAgg(AggregateInfo aggregateInfo, List<DataPartition> childFragmentDataPartition) {
+ // Condition1
+ if (ConnectContext.get().getSessionVariable().isDisableColocatePlan()) {
+ LOG.info("Agg node is not colocate in:" + ConnectContext.get().getQueryDetail().getQueryId()
Review comment:
debug level
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -475,7 +480,11 @@ private PlanFragment createHashJoinFragment(HashJoinNode node, PlanFragment righ
/**
* Colocate Join can be performed when the following 4 conditions are met at the same time.
+<<<<<<< HEAD
* 1. Session variables disable_colocate_plan = false
+=======
+ * 1. Session variables disable_colocate_plan = true
+>>>>>>> 26f4e1fa8 ([Colocate plan][Step1] Colocate join covers more situations)
Review comment:
Conflict?
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -974,6 +984,64 @@ private PlanFragment createAggregationFragment(
}
}
+ /**
+ * Colocate Agg can be performed when the following 2 conditions are met at the same time.
+ * 1. Session variables disable_colocate_plan = true
Review comment:
disable_colocate_plan=false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org