You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by va...@apache.org on 2025/05/22 18:35:48 UTC

(superset) branch fix/all-entities/make-button-visibility-dynamic updated: Addressing PR feedback

This is an automated email from the ASF dual-hosted git repository.

vavila pushed a commit to branch fix/all-entities/make-button-visibility-dynamic
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/fix/all-entities/make-button-visibility-dynamic by this push:
     new be5017c5f4 Addressing PR feedback
be5017c5f4 is described below

commit be5017c5f4a1555c90fc3ccbe78c93c9c4c60fac
Author: Vitor Avila <vi...@preset.io>
AuthorDate: Thu May 22 15:34:56 2025 -0300

    Addressing PR feedback
---
 .../src/features/allEntities/AllEntitiesTable.tsx    | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/superset-frontend/src/features/allEntities/AllEntitiesTable.tsx b/superset-frontend/src/features/allEntities/AllEntitiesTable.tsx
index 23cbb5712a..c5261e96ef 100644
--- a/superset-frontend/src/features/allEntities/AllEntitiesTable.tsx
+++ b/superset-frontend/src/features/allEntities/AllEntitiesTable.tsx
@@ -156,17 +156,15 @@ export default function AllEntitiesTable({
           )}
         </>
       ) : (
-        <>
-          <EmptyState
-            image="dashboard.svg"
-            size="large"
-            title={t('No entities have this tag currently assigned')}
-            {...(canEditTag && {
-              buttonAction: () => setShowTagModal(true),
-              buttonText: t('Add tag to entities'),
-            })}
-          />
-        </>
+        <EmptyState
+          image="dashboard.svg"
+          size="large"
+          title={t('No entities have this tag currently assigned')}
+          {...(canEditTag && {
+            buttonAction: () => setShowTagModal(true),
+            buttonText: t('Add tag to entities'),
+          })}
+        />
       )}
     </AllEntitiesTableContainer>
   );