You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/15 10:30:47 UTC

[GitHub] [dolphinscheduler-website] Tianqi-Dotes opened a new pull request #735: Proofreading dev documents under /user_doc/guide/installation

Tianqi-Dotes opened a new pull request #735:
URL: https://github.com/apache/dolphinscheduler-website/pull/735


   Proofreading dev documents under /user_doc/guide/installation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie merged pull request #735: Proofreading dev documents under /user_doc/guide/installation

Posted by GitBox <gi...@apache.org>.
zhongjiajie merged pull request #735:
URL: https://github.com/apache/dolphinscheduler-website/pull/735


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #735: Proofreading dev documents under /user_doc/guide/installation

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #735:
URL: https://github.com/apache/dolphinscheduler-website/pull/735#discussion_r827834531



##########
File path: docs/en-us/dev/user_doc/guide/installation/docker.md
##########
@@ -328,29 +326,30 @@ $ docker build --build-arg VERSION=1.3.8 -t apache/dolphinscheduler:1.3.8 .
 
 #### Build Multi-Platform Images
 
-Currently support to build images including `linux/amd64` and `linux/arm64` platform architecture, requirements:
+Currently, support build images including `linux/amd64` and `linux/arm64` platform architecture, requirements:
 
 1. Support [docker buildx](https://docs.docker.com/engine/reference/commandline/buildx/)
-2. Own the push permission of https://hub.docker.com/r/apache/dolphinscheduler (**Be cautious**: The build command will automatically push the multi-platform architecture images to the docker hub of apache/dolphinscheduler by default)
+2. Own the push permission of `https://hub.docker.com/r/apache/dolphinscheduler` (**Be cautious**: The build command will automatically push the multi-platform architecture images to the docker hub of `apache/dolphinscheduler` by default)
 
 Execute:
 
 ```bash
 $ docker login # login to push apache/dolphinscheduler
-$ bash ./docker/build/hooks/build
+$ bash ./docker/build/hooks/build x

Review comment:
       oh, my bad, thanks for your clarification




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #735: Proofreading dev documents under /user_doc/guide/installation

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #735:
URL: https://github.com/apache/dolphinscheduler-website/pull/735#discussion_r826824877



##########
File path: docs/en-us/dev/user_doc/guide/installation/docker.md
##########
@@ -328,29 +326,30 @@ $ docker build --build-arg VERSION=1.3.8 -t apache/dolphinscheduler:1.3.8 .
 
 #### Build Multi-Platform Images
 
-Currently support to build images including `linux/amd64` and `linux/arm64` platform architecture, requirements:
+Currently, support build images including `linux/amd64` and `linux/arm64` platform architecture, requirements:
 
 1. Support [docker buildx](https://docs.docker.com/engine/reference/commandline/buildx/)
-2. Own the push permission of https://hub.docker.com/r/apache/dolphinscheduler (**Be cautious**: The build command will automatically push the multi-platform architecture images to the docker hub of apache/dolphinscheduler by default)
+2. Own the push permission of `https://hub.docker.com/r/apache/dolphinscheduler` (**Be cautious**: The build command will automatically push the multi-platform architecture images to the docker hub of `apache/dolphinscheduler` by default)
 
 Execute:
 
 ```bash
 $ docker login # login to push apache/dolphinscheduler
-$ bash ./docker/build/hooks/build
+$ bash ./docker/build/hooks/build x

Review comment:
       Is it add `x` by mistake?
   ```suggestion
   $ bash ./docker/build/hooks/build
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler-website] Tianqi-Dotes commented on a change in pull request #735: Proofreading dev documents under /user_doc/guide/installation

Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on a change in pull request #735:
URL: https://github.com/apache/dolphinscheduler-website/pull/735#discussion_r827818196



##########
File path: docs/en-us/dev/user_doc/guide/installation/docker.md
##########
@@ -328,29 +326,30 @@ $ docker build --build-arg VERSION=1.3.8 -t apache/dolphinscheduler:1.3.8 .
 
 #### Build Multi-Platform Images
 
-Currently support to build images including `linux/amd64` and `linux/arm64` platform architecture, requirements:
+Currently, support build images including `linux/amd64` and `linux/arm64` platform architecture, requirements:
 
 1. Support [docker buildx](https://docs.docker.com/engine/reference/commandline/buildx/)
-2. Own the push permission of https://hub.docker.com/r/apache/dolphinscheduler (**Be cautious**: The build command will automatically push the multi-platform architecture images to the docker hub of apache/dolphinscheduler by default)
+2. Own the push permission of `https://hub.docker.com/r/apache/dolphinscheduler` (**Be cautious**: The build command will automatically push the multi-platform architecture images to the docker hub of `apache/dolphinscheduler` by default)
 
 Execute:
 
 ```bash
 $ docker login # login to push apache/dolphinscheduler
-$ bash ./docker/build/hooks/build
+$ bash ./docker/build/hooks/build x

Review comment:
       The 'x' is right. The tool is called 'buildX' the command is 'build x' and I have checked the origin document. It's fine.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org