You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Philip Bridger (JIRA)" <ji...@apache.org> on 2012/08/27 16:15:07 UTC

[jira] [Created] (AMQ-3994) DefaultDatabaseLocker will leak pooled connections on link failure

Philip Bridger created AMQ-3994:
-----------------------------------

             Summary: DefaultDatabaseLocker will leak pooled connections on link failure
                 Key: AMQ-3994
                 URL: https://issues.apache.org/jira/browse/AMQ-3994
             Project: ActiveMQ
          Issue Type: Bug
          Components: Broker
    Affects Versions: 5.6.0
            Reporter: Philip Bridger


When the broker has lost the connection to the database through external issues -- link or database goes down, the process broker will stop().
When it is shutting down, it calls on each component (service) to stop().
The DefaultDatabaseLocker when stopping will test the connection to see if it is open or not before calling close() on the connection. Given that the connection was closed due to a link failure, the connection is never returned to the pool, hence the leak.

In this same file there is a comment in start() which warns about being careful about connection leaks.




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (AMQ-3994) DefaultDatabaseLocker will leak pooled connections on link failure

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated AMQ-3994:
-----------------------------

      Component/s:     (was: Broker)
                   Message Store
    Fix Version/s: 5.7.0
    
> DefaultDatabaseLocker will leak pooled connections on link failure
> ------------------------------------------------------------------
>
>                 Key: AMQ-3994
>                 URL: https://issues.apache.org/jira/browse/AMQ-3994
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Message Store
>    Affects Versions: 5.6.0
>            Reporter: Philip Bridger
>            Assignee: Claus Ibsen
>             Fix For: 5.7.0
>
>         Attachments: DefaultDatabaseLocker.java.patch
>
>
> When the broker has lost the connection to the database through external issues -- link or database goes down, the process broker will stop().
> When it is shutting down, it calls on each component (service) to stop().
> The DefaultDatabaseLocker when stopping will test the connection to see if it is open or not before calling close() on the connection. Given that the connection was closed due to a link failure, the connection is never returned to the pool, hence the leak.
> In this same file there is a comment in start() which warns about being careful about connection leaks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (AMQ-3994) DefaultDatabaseLocker will leak pooled connections on link failure

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved AMQ-3994.
------------------------------

    Resolution: Fixed

Thanks for the patch.
                
> DefaultDatabaseLocker will leak pooled connections on link failure
> ------------------------------------------------------------------
>
>                 Key: AMQ-3994
>                 URL: https://issues.apache.org/jira/browse/AMQ-3994
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Message Store
>    Affects Versions: 5.6.0
>            Reporter: Philip Bridger
>            Assignee: Claus Ibsen
>             Fix For: 5.7.0
>
>         Attachments: DefaultDatabaseLocker.java.patch
>
>
> When the broker has lost the connection to the database through external issues -- link or database goes down, the process broker will stop().
> When it is shutting down, it calls on each component (service) to stop().
> The DefaultDatabaseLocker when stopping will test the connection to see if it is open or not before calling close() on the connection. Given that the connection was closed due to a link failure, the connection is never returned to the pool, hence the leak.
> In this same file there is a comment in start() which warns about being careful about connection leaks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (AMQ-3994) DefaultDatabaseLocker will leak pooled connections on link failure

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen reassigned AMQ-3994:
--------------------------------

    Assignee: Claus Ibsen
    
> DefaultDatabaseLocker will leak pooled connections on link failure
> ------------------------------------------------------------------
>
>                 Key: AMQ-3994
>                 URL: https://issues.apache.org/jira/browse/AMQ-3994
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Message Store
>    Affects Versions: 5.6.0
>            Reporter: Philip Bridger
>            Assignee: Claus Ibsen
>             Fix For: 5.7.0
>
>         Attachments: DefaultDatabaseLocker.java.patch
>
>
> When the broker has lost the connection to the database through external issues -- link or database goes down, the process broker will stop().
> When it is shutting down, it calls on each component (service) to stop().
> The DefaultDatabaseLocker when stopping will test the connection to see if it is open or not before calling close() on the connection. Given that the connection was closed due to a link failure, the connection is never returned to the pool, hence the leak.
> In this same file there is a comment in start() which warns about being careful about connection leaks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (AMQ-3994) DefaultDatabaseLocker will leak pooled connections on link failure

Posted by "Philip Bridger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philip Bridger updated AMQ-3994:
--------------------------------

    Attachment: DefaultDatabaseLocker.java.patch

Patch file from tag of 5.6.0

Apologies for not attaching it when creating the issue.

                
> DefaultDatabaseLocker will leak pooled connections on link failure
> ------------------------------------------------------------------
>
>                 Key: AMQ-3994
>                 URL: https://issues.apache.org/jira/browse/AMQ-3994
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.6.0
>            Reporter: Philip Bridger
>         Attachments: DefaultDatabaseLocker.java.patch
>
>
> When the broker has lost the connection to the database through external issues -- link or database goes down, the process broker will stop().
> When it is shutting down, it calls on each component (service) to stop().
> The DefaultDatabaseLocker when stopping will test the connection to see if it is open or not before calling close() on the connection. Given that the connection was closed due to a link failure, the connection is never returned to the pool, hence the leak.
> In this same file there is a comment in start() which warns about being careful about connection leaks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AMQ-3994) DefaultDatabaseLocker will leak pooled connections on link failure

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AMQ-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451285#comment-13451285 ] 

Claus Ibsen commented on AMQ-3994:
----------------------------------

Philip, you have marked [x] in patch available. Are you working on a patch?
                
> DefaultDatabaseLocker will leak pooled connections on link failure
> ------------------------------------------------------------------
>
>                 Key: AMQ-3994
>                 URL: https://issues.apache.org/jira/browse/AMQ-3994
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.6.0
>            Reporter: Philip Bridger
>
> When the broker has lost the connection to the database through external issues -- link or database goes down, the process broker will stop().
> When it is shutting down, it calls on each component (service) to stop().
> The DefaultDatabaseLocker when stopping will test the connection to see if it is open or not before calling close() on the connection. Given that the connection was closed due to a link failure, the connection is never returned to the pool, hence the leak.
> In this same file there is a comment in start() which warns about being careful about connection leaks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira