You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2017/10/18 19:07:20 UTC
Re: Review Request 62995: HIVE-17806: Create directory for metrics
file if it doesn't exist
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62995/
-----------------------------------------------------------
(Updated Oct. 18, 2017, 7:07 p.m.)
Review request for hive, Aihua Xu, Andrew Sherman, Janaki Lahorani, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar.
Changes
-------
Addressed code review comment from Vihang
Summary (updated)
-----------------
HIVE-17806: Create directory for metrics file if it doesn't exist
Bugs: HIVE-17806
https://issues.apache.org/jira/browse/HIVE-17806
Repository: hive-git
Description (updated)
-------
HIVE-17806: Create directory for metrics file if it doesn't exist
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java 96243cb74a154b9a639ffb080256c4b43bd35a4b
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java 254af7d4310578e3883c0dffa64bed0f823696ea
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/metrics/JsonReporter.java f71bb25463b56bc741f989454664397996b6a5cf
Diff: https://reviews.apache.org/r/62995/diff/3/
Changes: https://reviews.apache.org/r/62995/diff/2-3/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 62995: HIVE-17806 Create directory for metrics
file if it doesn't exist
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62995/
-----------------------------------------------------------
(Updated Oct. 19, 2017, 2 a.m.)
Review request for hive, Aihua Xu, Andrew Sherman, Janaki Lahorani, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar.
Changes
-------
Create temp directory for the test if it doesn't exist
Summary (updated)
-----------------
HIVE-17806 Create directory for metrics file if it doesn't exist
Bugs: HIVE-17806
https://issues.apache.org/jira/browse/HIVE-17806
Repository: hive-git
Description (updated)
-------
HIVE-17806 Create directory for metrics file if it doesn't exist
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java 96243cb74a154b9a639ffb080256c4b43bd35a4b
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java 254af7d4310578e3883c0dffa64bed0f823696ea
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/metrics/JsonReporter.java f71bb25463b56bc741f989454664397996b6a5cf
Diff: https://reviews.apache.org/r/62995/diff/4/
Changes: https://reviews.apache.org/r/62995/diff/3-4/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 62995: HIVE-17806: Create directory for metrics
file if it doesn't exist
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62995/#review188551
-----------------------------------------------------------
Ship it!
Ship It!
- Vihang Karajgaonkar
On Oct. 18, 2017, 7:07 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62995/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2017, 7:07 p.m.)
>
>
> Review request for hive, Aihua Xu, Andrew Sherman, Janaki Lahorani, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar.
>
>
> Bugs: HIVE-17806
> https://issues.apache.org/jira/browse/HIVE-17806
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-17806: Create directory for metrics file if it doesn't exist
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java 96243cb74a154b9a639ffb080256c4b43bd35a4b
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java 254af7d4310578e3883c0dffa64bed0f823696ea
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/metrics/JsonReporter.java f71bb25463b56bc741f989454664397996b6a5cf
>
>
> Diff: https://reviews.apache.org/r/62995/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>