You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/03/23 02:21:11 UTC

[GitHub] [openwhisk-wskdeploy] advancedwebdeveloper opened a new pull request #1132: Migrate to Go 1.16.2

advancedwebdeveloper opened a new pull request #1132:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1132


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-wskdeploy] advancedwebdeveloper commented on pull request #1132: Migrate to Go 1.16.2

Posted by GitBox <gi...@apache.org>.
advancedwebdeveloper commented on pull request #1132:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1132#issuecomment-808327557


   I shall try to operate from the shell (not via Github's UI). Give me some time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-wskdeploy] mrutkows commented on a change in pull request #1132: Migrate to Go 1.16.2

Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #1132:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1132#discussion_r608774556



##########
File path: Dockerfile
##########
@@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-FROM golang:1.15

Review comment:
       You will also need to update Travis:
   https://github.com/apache/openwhisk-wskdeploy/blob/master/.travis.yml




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-wskdeploy] mrutkows commented on a change in pull request #1132: Migrate to Go 1.16.2

Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #1132:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1132#discussion_r608774556



##########
File path: Dockerfile
##########
@@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-FROM golang:1.15

Review comment:
       You will also need to update Travis:
   https://github.com/apache/openwhisk-wskdeploy/blob/master/.travis.yml
   
   and update the README as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-wskdeploy] advancedwebdeveloper removed a comment on pull request #1132: Migrate to Go 1.16.2

Posted by GitBox <gi...@apache.org>.
advancedwebdeveloper removed a comment on pull request #1132:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1132#issuecomment-808327557


   I shall try to operate from the shell (not via Github's UI). Give me some time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-wskdeploy] mrutkows commented on pull request #1132: Migrate to Go 1.16.2

Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #1132:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1132#issuecomment-815017500


   > > Please also use "go edit" to update go.mod to the same version
   > 
   > Hm, I got this:
   > 
   > > $ go edit
   > > go edit: unknown command
   > > Run 'go help' for usage.
   > 
   > I am using
   > 
   > > $ go version
   > > go version go1.16.2 windows/amd64
   
   Sorry, as the README says it is 
   ```
   go mod edit
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [openwhisk-wskdeploy] advancedwebdeveloper commented on pull request #1132: Migrate to Go 1.16.2

Posted by GitBox <gi...@apache.org>.
advancedwebdeveloper commented on pull request #1132:
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1132#issuecomment-808329649


   > Please also use "go edit" to update go.mod to the same version
   
   Hm, I got this:
   
   > $ go edit
   > go edit: unknown command
   > Run 'go help' for usage.
   
   I am using
   
   > $ go version
   > go version go1.16.2 windows/amd64
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org