You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/04/06 05:43:13 UTC
Review Request 45800: Moved long running framework to use the v1 API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-4982
https://issues.apache.org/jira/browse/MESOS-4982
Repository: mesos
Description
-------
See summary. Also removed the AuthN code. Once, the library
supports AuthN we can bring it back.
Diffs
-----
src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0
Diff: https://reviews.apache.org/r/45800/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 45800: Moved long running framework to use the v1
API.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On April 6, 2016, 10:10 a.m., Joseph Wu wrote:
> > src/examples/long_lived_framework.cpp, lines 217-221
> > <https://reviews.apache.org/r/45800/diff/1/?file=1327282#file1327282line217>
> >
> > Would be nice to log something here.
>
> Anand Mazumdar wrote:
> Logging an `ERROR` would be useful. I had copied over from the old interface that did not use to log anything. Does this sound reasonable to you?
Sounds good. (Logging the `RESCIND` event might also be useful.)
> On April 6, 2016, 10:10 a.m., Joseph Wu wrote:
> > src/examples/long_lived_framework.cpp, line 593
> > <https://reviews.apache.org/r/45800/diff/1/?file=1327282#file1327282line593>
> >
> > Does the HTTP scheduler driver initialize glog (like the old scheduler driver does)?
>
> Anand Mazumdar wrote:
> It doesn't. We should ideally initialize logging inside the framework itself.
The only consequence of not initializing glog is that glog will print a warning the first time we hit a `LOG(...) << ...` line.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127365
-----------------------------------------------------------
On April 6, 2016, 10:45 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 10:45 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
>
>
> Diffs
> -----
>
> src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0
>
> Diff: https://reviews.apache.org/r/45800/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 45800: Moved long running framework to use the v1
API.
Posted by Anand Mazumdar <ma...@gmail.com>.
> On April 6, 2016, 5:10 p.m., Joseph Wu wrote:
> > src/examples/long_lived_framework.cpp, line 593
> > <https://reviews.apache.org/r/45800/diff/1/?file=1327282#file1327282line593>
> >
> > Does the HTTP scheduler driver initialize glog (like the old scheduler driver does)?
It doesn't. We should ideally initialize logging inside the framework itself.
> On April 6, 2016, 5:10 p.m., Joseph Wu wrote:
> > src/examples/long_lived_framework.cpp, lines 217-221
> > <https://reviews.apache.org/r/45800/diff/1/?file=1327282#file1327282line217>
> >
> > Would be nice to log something here.
Logging an `ERROR` would be useful. I had copied over from the old interface that did not use to log anything. Does this sound reasonable to you?
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127365
-----------------------------------------------------------
On April 6, 2016, 5:45 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 5:45 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
>
>
> Diffs
> -----
>
> src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0
>
> Diff: https://reviews.apache.org/r/45800/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 45800: Moved long running framework to use the v1
API.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127365
-----------------------------------------------------------
LGTM.
src/examples/long_lived_framework.cpp (lines 216 - 220)
<https://reviews.apache.org/r/45800/#comment190648>
Would be nice to log something here.
src/examples/long_lived_framework.cpp (line 590)
<https://reviews.apache.org/r/45800/#comment190652>
Does the HTTP scheduler driver initialize glog (like the old scheduler driver does)?
- Joseph Wu
On April 5, 2016, 8:43 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 8:43 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
>
>
> Diffs
> -----
>
> src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0
>
> Diff: https://reviews.apache.org/r/45800/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 45800: Moved long running framework to use the v1
API.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127286
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45067, 45440, 45799, 45800]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 6, 2016, 3:43 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 3:43 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
>
>
> Diffs
> -----
>
> src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0
>
> Diff: https://reviews.apache.org/r/45800/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 45800: Moved long running framework to use the v1
API.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127501
-----------------------------------------------------------
Bad patch!
Reviews applied: [45800, 45799, 45440, 45067]
Failed command: ./support/apply-review.sh -n -r 45067
Error:
2016-04-06 23:10:16 URL:https://reviews.apache.org/r/45067/diff/raw/ [13287/13287] -> "45067.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.
Full log: https://builds.apache.org/job/mesos-reviewbot/12365/console
- Mesos ReviewBot
On April 6, 2016, 5:45 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 5:45 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
>
>
> Diffs
> -----
>
> src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0
>
> Diff: https://reviews.apache.org/r/45800/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 45800: Moved long running framework to use the v1
API.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/
-----------------------------------------------------------
(Updated April 7, 2016, 9:24 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-4982
https://issues.apache.org/jira/browse/MESOS-4982
Repository: mesos
Description
-------
See summary. Also removed the AuthN code. Once, the library
supports AuthN we can bring it back.
Diffs (updated)
-----
src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0
Diff: https://reviews.apache.org/r/45800/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 45800: Moved long running framework to use the v1
API.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/
-----------------------------------------------------------
(Updated April 6, 2016, 5:45 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comments from Joseph
Bugs: MESOS-4982
https://issues.apache.org/jira/browse/MESOS-4982
Repository: mesos
Description
-------
See summary. Also removed the AuthN code. Once, the library
supports AuthN we can bring it back.
Diffs (updated)
-----
src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0
Diff: https://reviews.apache.org/r/45800/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar