[GitHub] [beam] udim commented on a change in pull request #11502: [BEAM-9797] use tox for license pulling

[GitBox <gi...@apache.org>]

udim commented on a change in pull request #11502:
URL: https://github.com/apache/beam/pull/11502#discussion_r414207242



##########
File path: sdks/java/container/license_scripts/license_script.sh
##########
@@ -15,39 +15,33 @@
  # limitations under the License.
 
 set -e
+ROOT_DIR=$(pwd)
+CONTAINER_DIR="$ROOT_DIR/sdks/java/container"
+
 # reports are generated at ~/beam/java_third_party_licenses
 ./gradlew generateLicenseReport --rerun-tasks
 
-# install packages needed for pull_licenses_java.py
-pip install "beautifulsoup4>=4.9.0,<5.0"
-pip install "future>=0.16.0,<1.0.0"
-pip install "pyyaml>=3.12,<6.0.0"
-pip install "tenacity>=5.0.2,<6.0"
+# pip install 'tox>=3.14.6,<3.15.0'
+pip install --no-cache-dir tox==3.11.1

Review comment:
       The solution could be to do something like:
   ```sh
   # Creates a new directory $env_path and installs a virtual environment in it.
   env_path=$ROOT_DIR/build/license_scripts_env
   virtualenv $env_path --python python3.7
   source $env_path/bin/activate
   # Install tox, or just install the packages directly. Might be less complicated to skip using tox in this case.
   pip install ...
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org