[GitHub] [arrow] amol- commented on pull request #10650: ARROW-13058: This is a draft to provide save-report

[GitBox <gi...@apache.org>]

amol- commented on pull request #10650:
URL: https://github.com/apache/arrow/pull/10650#issuecomment-881308559


   @pachadotdev notice that there are various indentation/styling error that make the `Dev / Lint` step of the CI fail.
   You might want to run `archery lint --python --fix` to fix them 
   
   ```
   /arrow/dev/archery/archery/crossbow/cli.py:244:1: W293 blank line contains whitespace
   /arrow/dev/archery/archery/crossbow/cli.py:247:1: W293 blank line contains whitespace
   /arrow/dev/archery/archery/crossbow/cli.py:248:8: F821 undefined name 'fetch'
   /arrow/dev/archery/archery/crossbow/cli.py:252:14: F821 undefined name 'JsonReport'
   /arrow/dev/archery/archery/crossbow/reports.py:28:1: E302 expected 2 blank lines, found 1
   /arrow/dev/archery/archery/crossbow/reports.py:36:1: E302 expected 2 blank lines, found 1
   /arrow/dev/archery/archery/crossbow/reports.py:141:24: E203 whitespace before ':'
   /arrow/dev/archery/archery/crossbow/reports.py:142:23: E203 whitespace before ':'
   /arrow/dev/archery/archery/crossbow/reports.py:143:25: E203 whitespace before ':'
   /arrow/dev/archery/archery/crossbow/reports.py:144:28: E203 whitespace before ':'
   /arrow/dev/archery/archery/crossbow/reports.py:152:1: W293 blank line contains whitespace
   INFO:archery:Running cmake-format linters
   INFO:archery:Running apache-rat linter
   INFO:archery:Running R linter
   INFO:archery:Running Docker linter
   --- original//arrow/dev/archery/archery/crossbow/cli.py
   +++ fixed//arrow/dev/archery/archery/crossbow/cli.py
   @@ -241,10 +241,10 @@
        Just print there the state of the job
        """
        output = obj['output']
   -    
   +
        queue = obj['queue']
        print(dir(queue))
   -    
   +
        if fetch:
            queue.fetch()
    
   --- original//arrow/dev/archery/archery/crossbow/reports.py
   +++ fixed//arrow/dev/archery/archery/crossbow/reports.py
   @@ -25,6 +25,8 @@
    import json
    
    # TODO(kszucs): use archery.report.JinjaReport instead
   +
   +
    class Report:
    
        def __init__(self, job):
   @@ -32,6 +34,7 @@
    
        def show(self):
            raise NotImplementedError()
   +
    
    class ConsoleReport(Report):
        """Report the status of a Job to the console using click"""
   @@ -138,10 +141,10 @@
            json_tasks = []
            for task_name, task in tasks.items():
                json_tasks.append({
   -                "build" : task_name,
   -                "link" : self.url(task.branch),
   -                "status" : task.status().combined_state.upper(),
   -                "timestamp" : date})
   +                "build": task_name,
   +                "link": self.url(task.branch),
   +                "status": task.status().combined_state.upper(),
   +                "timestamp": date})
    
            return json_tasks
    
   @@ -149,7 +152,7 @@
            tasks = self.tasks_to_dict(self.today_str(), self.job.tasks.items())
            json_str = json.dump(tasks)
            return json_str
   -     
   +
    
    class EmailReport(Report):
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org