You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by olegz <gi...@git.apache.org> on 2016/04/14 14:32:42 UTC
[GitHub] nifi pull request: NIFI-1764 fixed NPE in PutKafka
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/350
NIFI-1764 fixed NPE in PutKafka
NIFI-1764 removed obsolete comment for MESSAGE_DELIMITER
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-1764
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/350.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #350
----
commit a0564c433a076f5ce4378e0518128928aaee5d98
Author: Oleg Zhurakousky <ol...@suitcase.io>
Date: 2016-04-14T12:30:11Z
NIFI-1764 fixed NPE in PutKafka
NIFI-1764 removed obsolete comment for MESSAGE_DELIMITER
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1764 fixed NPE in PutKafka
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/350#issuecomment-212597713
Closing it after discussing it with @joewitt. Will be addressed as part of the https://github.com/apache/nifi/pull/366 PR since there are already dependency on renaming/refactoring StreamScanner
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1764 fixed NPE in PutKafka
Posted by olegz <gi...@git.apache.org>.
Github user olegz closed the pull request at:
https://github.com/apache/nifi/pull/350
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1764 fixed NPE in PutKafka
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/350#issuecomment-211148835
This is most likely a no-merge PR. There is some work that is currently being done by @joewitt and elements of this PR will already be there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1764 fixed NPE in PutKafka
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/350#issuecomment-212598568
thanks Oleg. I'd like to review this as part of the larger #366 effort.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---