You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/10/10 08:47:21 UTC

[PR] perf(pr-management-stack-review): resolve, map and post as code, one file per finding class [magpie]

potiuk opened a new pull request, #1582:
URL: https://github.com/apache/magpie/pull/1582

   ## Summary
   
   - Stack review already ran two detector scripts; everything around them was prose: resolving the stack and trunk chain, the gate and stop decisions, the CI cells, the size estimate, mapping detector fields to severities, the verdict, the finding order, the marker lookup and the heads-changed check.
   - The detectors move into `tools/pr-management` (`pr_management.stack_review.stack_chain` / `stack_ledger`, byte-identical apart from imports), and the rest becomes `pr-management stack-review resolve | findings | verdict | post | residue-command` over reads saved with `vetted-op-read --save`.
   - The agent keeps the reading that needs judgement: whether a fix is at its own head, wrong-layer changes, the narrative and residue tokens.
   - Each finding class, verdict and step outcome has its own document under `classifications/`.
   
   ## Security notes
   
   Every command printed for the agent to run is built with `shlex.join` from validated values.
   
   ## Type of change
   
   - [x] Skill change — eval fixtures updated below
   - [x] Python package
   
   ## Test plan
   
   - [x] `prek run --all-files` passes
   - [x] `tools/pr-management` pytest / ruff / mypy
   - [x] Mechanical gate, finding, verdict and posting cases are now pytest cases
   - [x] Judgement suites `step-3-structural-findings` / `step-4-reading-plan`, now extracting the class and verdict docs they need: 11/11 pass
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [x] Yes — Claude Code (Opus 5). I reviewed the diff and the test results; commits carry `Generated-by:`.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_01GTPsZ5aEE5bUVYqp47Dpvv
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] perf(pr-management-stack-review): resolve, map and post as code, one file per finding class [magpie]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1582:
URL: https://github.com/apache/magpie/pull/1582


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org