You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/08/04 17:14:51 UTC

[GitHub] ashb commented on a change in pull request #3653: [AIRFLOW-2811] Fix scheduler_ops_metrics.py to work

ashb commented on a change in pull request #3653: [AIRFLOW-2811] Fix scheduler_ops_metrics.py to work
URL: https://github.com/apache/incubator-airflow/pull/3653#discussion_r207714253
 
 

 ##########
 File path: scripts/perf/scheduler_ops_metrics.py
 ##########
 @@ -178,6 +181,17 @@ def set_dags_paused_state(is_paused):
 
 
 def main():
+    global MAX_RUNTIME_SECS
+    if 1 < len(sys.argv):
 
 Review comment:
   This is an un-expected way of expressing it. Could you swap it so that `len()` is on the left-hand-side of the operator please?
   
   (Sorry to such a small nity-picky change)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services