You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/22 09:40:50 UTC
[GitHub] [flink] zentol opened a new pull request #10923:
[FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
zentol opened a new pull request #10923: [FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
URL: https://github.com/apache/flink/pull/10923
Removes `TaskExecutorPartitionLifecycleTest#runInTaskExecutorThreadAndWait()` and refactors existing usages.
The method did not achieve the desired effect of running the action in the TE main thread. Given that the test has not shown instabilities despite this we can conclude that these actions can just be executed in the tests main thread instead.
Additionally, this test removes/replaces accesses to the JobManagerTable of the TaskExecutor.
The first access was removed since it is not really necessary since it effectively verified the test setup.
The second access was replaced with a check for whether the disconnect-from-JM future has been completed, which _should_ behave the same way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10923:
[FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10923: [FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
URL: https://github.com/apache/flink/pull/10923#discussion_r369668495
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorPartitionLifecycleTest.java
##########
@@ -254,7 +249,7 @@ public void testPartitionPromotion() throws Exception {
testPartitionRelease(
(jobId, partitionId, taskExecutor, taskExecutorGateway, partitionTracker) -> {
final CompletableFuture<Collection<ResultPartitionID>> releasePartitionsFuture = new CompletableFuture<>();
- runInTaskExecutorThreadAndWait(taskExecutor, () -> partitionTracker.setPromotePartitionsConsumer(releasePartitionsFuture::complete));
+ partitionTracker.setPromotePartitionsConsumer(releasePartitionsFuture::complete);
Review comment:
I think this is not 100% correct as the internal `TestingTaskExecutorPartitionTracker#promotePartitionsConsumer` field is not volatile. Hence, the `TaskExecutor` might read a stale value. I would suggest to either setup these things before creating the `TaskExecutor` or if this is not possible, then make the fields volatile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10923:
[FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10923: [FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
URL: https://github.com/apache/flink/pull/10923#discussion_r369735019
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorPartitionLifecycleTest.java
##########
@@ -254,7 +249,7 @@ public void testPartitionPromotion() throws Exception {
testPartitionRelease(
(jobId, partitionId, taskExecutor, taskExecutorGateway, partitionTracker) -> {
final CompletableFuture<Collection<ResultPartitionID>> releasePartitionsFuture = new CompletableFuture<>();
- runInTaskExecutorThreadAndWait(taskExecutor, () -> partitionTracker.setPromotePartitionsConsumer(releasePartitionsFuture::complete));
+ partitionTracker.setPromotePartitionsConsumer(releasePartitionsFuture::complete);
Review comment:
On a more serious note I wanted to push this back a bit since it looked like a bigger change, and I didn't want to delay the removal of this method.
But I think I may have a quick solution that I'll try tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10923: [FLINK-15691][tests]
Remove runInTaskExecutorThreadAndWait()
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10923: [FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
URL: https://github.com/apache/flink/pull/10923#issuecomment-577180279
<!--
Meta data
Hash:c271c86281723f9cfa99ed95d6073c280a753e25 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c271c86281723f9cfa99ed95d6073c280a753e25
-->
## CI report:
* c271c86281723f9cfa99ed95d6073c280a753e25 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10923:
[FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10923: [FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
URL: https://github.com/apache/flink/pull/10923#issuecomment-577180279
<!--
Meta data
Hash:c271c86281723f9cfa99ed95d6073c280a753e25 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145556958 TriggerType:PUSH TriggerID:c271c86281723f9cfa99ed95d6073c280a753e25
Hash:c271c86281723f9cfa99ed95d6073c280a753e25 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4553 TriggerType:PUSH TriggerID:c271c86281723f9cfa99ed95d6073c280a753e25
-->
## CI report:
* c271c86281723f9cfa99ed95d6073c280a753e25 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145556958) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4553)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10923:
[FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10923: [FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
URL: https://github.com/apache/flink/pull/10923#issuecomment-577180279
<!--
Meta data
Hash:c271c86281723f9cfa99ed95d6073c280a753e25 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145556958 TriggerType:PUSH TriggerID:c271c86281723f9cfa99ed95d6073c280a753e25
Hash:c271c86281723f9cfa99ed95d6073c280a753e25 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4553 TriggerType:PUSH TriggerID:c271c86281723f9cfa99ed95d6073c280a753e25
Hash:5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145615905 TriggerType:PUSH TriggerID:5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49
Hash:5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4565 TriggerType:PUSH TriggerID:5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49
-->
## CI report:
* c271c86281723f9cfa99ed95d6073c280a753e25 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145556958) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4553)
* 5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145615905) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4565)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10923:
[FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10923: [FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
URL: https://github.com/apache/flink/pull/10923#issuecomment-577180279
<!--
Meta data
Hash:c271c86281723f9cfa99ed95d6073c280a753e25 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145556958 TriggerType:PUSH TriggerID:c271c86281723f9cfa99ed95d6073c280a753e25
Hash:c271c86281723f9cfa99ed95d6073c280a753e25 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4553 TriggerType:PUSH TriggerID:c271c86281723f9cfa99ed95d6073c280a753e25
Hash:5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145615905 TriggerType:PUSH TriggerID:5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49
Hash:5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4565 TriggerType:PUSH TriggerID:5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49
-->
## CI report:
* c271c86281723f9cfa99ed95d6073c280a753e25 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145556958) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4553)
* 5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145615905) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4565)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #10923: [FLINK-15691][tests]
Remove runInTaskExecutorThreadAndWait()
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #10923: [FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
URL: https://github.com/apache/flink/pull/10923
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10923:
[FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10923: [FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
URL: https://github.com/apache/flink/pull/10923#discussion_r369732711
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorPartitionLifecycleTest.java
##########
@@ -254,7 +249,7 @@ public void testPartitionPromotion() throws Exception {
testPartitionRelease(
(jobId, partitionId, taskExecutor, taskExecutorGateway, partitionTracker) -> {
final CompletableFuture<Collection<ResultPartitionID>> releasePartitionsFuture = new CompletableFuture<>();
- runInTaskExecutorThreadAndWait(taskExecutor, () -> partitionTracker.setPromotePartitionsConsumer(releasePartitionsFuture::complete));
+ partitionTracker.setPromotePartitionsConsumer(releasePartitionsFuture::complete);
Review comment:
hasn't failed so far 🙈
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10923: [FLINK-15691][tests]
Remove runInTaskExecutorThreadAndWait()
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10923: [FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
URL: https://github.com/apache/flink/pull/10923#issuecomment-577096773
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c271c86281723f9cfa99ed95d6073c280a753e25 (Wed Jan 22 09:43:50 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15691).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10923:
[FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10923: [FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
URL: https://github.com/apache/flink/pull/10923#issuecomment-577180279
<!--
Meta data
Hash:c271c86281723f9cfa99ed95d6073c280a753e25 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145556958 TriggerType:PUSH TriggerID:c271c86281723f9cfa99ed95d6073c280a753e25
Hash:c271c86281723f9cfa99ed95d6073c280a753e25 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4553 TriggerType:PUSH TriggerID:c271c86281723f9cfa99ed95d6073c280a753e25
Hash:5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49
-->
## CI report:
* c271c86281723f9cfa99ed95d6073c280a753e25 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145556958) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4553)
* 5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10923:
[FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10923: [FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
URL: https://github.com/apache/flink/pull/10923#issuecomment-577180279
<!--
Meta data
Hash:c271c86281723f9cfa99ed95d6073c280a753e25 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145556958 TriggerType:PUSH TriggerID:c271c86281723f9cfa99ed95d6073c280a753e25
Hash:c271c86281723f9cfa99ed95d6073c280a753e25 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4553 TriggerType:PUSH TriggerID:c271c86281723f9cfa99ed95d6073c280a753e25
-->
## CI report:
* c271c86281723f9cfa99ed95d6073c280a753e25 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145556958) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4553)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10923:
[FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10923: [FLINK-15691][tests] Remove runInTaskExecutorThreadAndWait()
URL: https://github.com/apache/flink/pull/10923#issuecomment-577180279
<!--
Meta data
Hash:c271c86281723f9cfa99ed95d6073c280a753e25 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145556958 TriggerType:PUSH TriggerID:c271c86281723f9cfa99ed95d6073c280a753e25
Hash:c271c86281723f9cfa99ed95d6073c280a753e25 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4553 TriggerType:PUSH TriggerID:c271c86281723f9cfa99ed95d6073c280a753e25
Hash:5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145615905 TriggerType:PUSH TriggerID:5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49
Hash:5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4565 TriggerType:PUSH TriggerID:5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49
-->
## CI report:
* c271c86281723f9cfa99ed95d6073c280a753e25 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145556958) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4553)
* 5da7ad7c8bdd667a81c5f3c3366257e02e2dcf49 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145615905) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4565)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services