You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2015/08/27 12:35:14 UTC
qpid-jms git commit: QPIDJMS-104: avoid iterating listeners on
message arrival if the collection is empty
Repository: qpid-jms
Updated Branches:
refs/heads/master 214045ccd -> cf492a102
QPIDJMS-104: avoid iterating listeners on message arrival if the collection is empty
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/cf492a10
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/cf492a10
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/cf492a10
Branch: refs/heads/master
Commit: cf492a102ad16a6ad9116f61650666054c6c53f6
Parents: 214045c
Author: Robert Gemmell <ro...@apache.org>
Authored: Thu Aug 27 11:34:50 2015 +0100
Committer: Robert Gemmell <ro...@apache.org>
Committed: Thu Aug 27 11:34:50 2015 +0100
----------------------------------------------------------------------
.../java/org/apache/qpid/jms/JmsConnection.java | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/cf492a10/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java
index 3367212..cf1bb31 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java
@@ -1008,15 +1008,16 @@ public class JmsConnection implements Connection, TopicConnection, QueueConnecti
// Run the application callbacks on the connection executor to allow the provider to
// return to its normal processing without waiting for client level processing to finish.
- //TODO: if this is usually empty, optimise this a little by skipping iteration?
- for (final JmsConnectionListener listener : connectionListeners) {
- executor.submit(new Runnable() {
+ if (!connectionListeners.isEmpty()) {
+ for (final JmsConnectionListener listener : connectionListeners) {
+ executor.submit(new Runnable() {
- @Override
- public void run() {
- listener.onInboundMessage(envelope);
- }
- });
+ @Override
+ public void run() {
+ listener.onInboundMessage(envelope);
+ }
+ });
+ }
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org