You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2015/02/02 21:23:37 UTC
[jira] [Commented] (WW-4452) s:optiontransferselect javascript
functions no longer work with negative integer keys
[ https://issues.apache.org/jira/browse/WW-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301854#comment-14301854 ]
ASF subversion and git services commented on WW-4452:
-----------------------------------------------------
Commit 312a2717cf2f7094e42a83f7f05cb493c3d393c8 in struts's branch refs/heads/develop from [~lukaszlenart]
[ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=312a271 ]
WW-4452 Solves problem with using -1 as headerKey
> s:optiontransferselect javascript functions no longer work with negative integer keys
> -------------------------------------------------------------------------------------
>
> Key: WW-4452
> URL: https://issues.apache.org/jira/browse/WW-4452
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.3.20
> Reporter: Brent N Atkinson
> Fix For: 2.3.22
>
>
> It appears that the change made to fix WW-4365 broke the javascript functions used to implement onclick handlers for the s:optiontransferselect tag.
> While attempting an upgrade to 2.3.20 from 2.3.16.3, all pages containing tags like the following are broken (tests fail):
> {code}
> <s:optiontransferselect multiple="true" headerKey="-1" doubleHeaderKey="-1" multiple="true" doubleMultiple="true" addAllToRightOnclick="selectAllOptionsExceptSome(document.getElementById('saveBuildDefinitionTemplate_selectedBuildDefinitionIds'), 'key', '-1');" />
> {code}
> Since the regular expression used to match the header keys now always attempts to match on word boundary, the change introduced in WW-4365, it will not match negative numbers like '-1'. This is likely to break a number of applications since [the struts 2 documentation for optiontransferselect|https://cwiki.apache.org/confluence/display/WW/optiontransferselect] suggests using '-1'.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)