You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/04/18 19:18:00 UTC
[jira] [Commented] (AIRFLOW-7111) Expose generate_presigned_url of
boto3 to S3Hook
[ https://issues.apache.org/jira/browse/AIRFLOW-7111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086606#comment-17086606 ]
ASF GitHub Bot commented on AIRFLOW-7111:
-----------------------------------------
jcarless commented on pull request #8441: [AIRFLOW-7111] Add generate_presigned_url method to S3Hook
URL: https://github.com/apache/airflow/pull/8441
Boto3 generate_presigned_url exposed to S3Hook.
---
- [ x ] Description above provides context of the change
- [ x ] Unit tests coverage for changes (not needed for documentation changes)
- [ x ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ x ] Relevant documentation is updated including usage instructions.
- [ x ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Expose generate_presigned_url of boto3 to S3Hook
> ------------------------------------------------
>
> Key: AIRFLOW-7111
> URL: https://issues.apache.org/jira/browse/AIRFLOW-7111
> Project: Apache Airflow
> Issue Type: Improvement
> Components: aws
> Affects Versions: 1.10.9
> Reporter: korni
> Assignee: Jerome Carless
> Priority: Major
> Labels: S3, S3Hook, aws, easyfix, gsoc, gsoc2020
>
> boto3 has {{generate_presigned_url which should be exposed in the Hook:}}
> {{[https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3.html#S3.Client.generate_presigned_url]}}
> {{generate_presigned_url}}(_ClientMethod_, _Params=None_, _ExpiresIn=3600_, _HttpMethod=None_)
> Generate a presigned url given a client, its method, and arguments
> Parameters
> * *ClientMethod* (_string_) -- The client method to presign for
> * *Params* (_dict_) -- The parameters normally passed to {{ClientMethod}}.
> * *ExpiresIn* (_int_) -- The number of seconds the presigned url is valid for. By default it expires in an hour (3600 seconds)
> * *HttpMethod* (_string_) -- The http method to use on the generated url. By default, the http method is whatever is used in the method's model.
> Returns The presigned url
--
This message was sent by Atlassian Jira
(v8.3.4#803005)