You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/03 21:58:07 UTC

[GitHub] [spark] rdblue commented on pull request #31451: [WIP][SPARK-34338][SQL] Report metrics from Datasource v2 scan

rdblue commented on pull request #31451:
URL: https://github.com/apache/spark/pull/31451#issuecomment-772851822


   I think that this could use some tests. It would be easier to add tests if it were split to add the interfaces, a batch implementation (with tests), and a stream implementation (with stream tests).
   
   Thanks for working on this, @viirya!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org