[GitHub] [ignite-3] sanpwc commented on a change in pull request #332: IGNITE-15444 stop MetaStorageManager

[GitBox <gi...@apache.org>]

sanpwc commented on a change in pull request #332:
URL: https://github.com/apache/ignite-3/pull/332#discussion_r711931436



##########
File path: modules/metastorage-client/src/main/java/org/apache/ignite/internal/metastorage/client/CursorImpl.java
##########
@@ -101,10 +104,10 @@
                         cursorId -> metaStorageRaftGrpSvc.<Boolean>run(new CursorHasNextCommand(cursorId))).get();
             }
             catch (InterruptedException | ExecutionException e) {
-                if (e.getCause().getClass().equals(NodeStoppingException.class))
+                if (e.getCause() != null && e.getCause().getClass().equals(NodeStoppingException.class))
                     return false;
 
-                LOG.error("Unable to evaluate cursor hasNext command", e);
+                LOG.warn("Unable to evaluate cursor hasNext command");

Review comment:
       Why it's warn and not an error?
   Why we don't propagate e to log?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org