You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Dian Fu <di...@gmail.com> on 2015/05/28 04:02:42 UTC
Review Request 34745: SQOOP-2121: Sqoop2: Show job should show
connection information
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34745/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
When running show job user can see what connectors are in use:
sqoop:000> show job
+----+-------------+----------------+--------------+---------+
| Id | Name | From Connector | To Connector | Enabled |
+----+-------------+----------------+--------------+---------+
| 3 | mysql2hdfs2 | 4 | 3 | true |
| 4 | hdfs2mysql2 | 3 | 4 | true |
| 1 | mysql2hdfs | 4 | 3 | true |
| 2 | hdfs2mysql | 3 | 4 | true |
+----+-------------+----------------+--------------+---------+
I think that it would be more useful to show the connection instead (or in addition).
Diffs
-----
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java fab99db
Diff: https://reviews.apache.org/r/34745/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 34745: SQOOP-2121: Sqoop2: Show job should show
connection information
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34745/#review85524
-----------------------------------------------------------
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java
<https://reviews.apache.org/r/34745/#comment137092>
This looks great! A couple of thoughts:
# from and to connectors are guaranteed... but defensive programming is fine by me.
# Maybe get the link name and connector name? So that it shows up this way: Link (Connector). My understanding is that groovy can even have different colors if you want to get fancy.
- Abraham Elmahrek
On May 28, 2015, 2:02 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34745/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 2:02 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> When running show job user can see what connectors are in use:
> sqoop:000> show job
> +----+-------------+----------------+--------------+---------+
> | Id | Name | From Connector | To Connector | Enabled |
> +----+-------------+----------------+--------------+---------+
> | 3 | mysql2hdfs2 | 4 | 3 | true |
> | 4 | hdfs2mysql2 | 3 | 4 | true |
> | 1 | mysql2hdfs | 4 | 3 | true |
> | 2 | hdfs2mysql | 3 | 4 | true |
> +----+-------------+----------------+--------------+---------+
> I think that it would be more useful to show the connection instead (or in addition).
>
>
> Diffs
> -----
>
> shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java fab99db
>
> Diff: https://reviews.apache.org/r/34745/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 34745: SQOOP-2121: Sqoop2: Show job should show
connection information
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34745/
-----------------------------------------------------------
(Updated June 2, 2015, 3:24 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
When running show job user can see what connectors are in use:
sqoop:000> show job
+----+-------------+----------------+--------------+---------+
| Id | Name | From Connector | To Connector | Enabled |
+----+-------------+----------------+--------------+---------+
| 3 | mysql2hdfs2 | 4 | 3 | true |
| 4 | hdfs2mysql2 | 3 | 4 | true |
| 1 | mysql2hdfs | 4 | 3 | true |
| 2 | hdfs2mysql | 3 | 4 | true |
+----+-------------+----------------+--------------+---------+
I think that it would be more useful to show the connection instead (or in addition).
Diffs (updated)
-----
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java fab99db
Diff: https://reviews.apache.org/r/34745/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 34745: SQOOP-2121: Sqoop2: Show job should show
connection information
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34745/#review85518
-----------------------------------------------------------
Ship it!
LGTM
- richard zhou
On May 28, 2015, 2:02 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34745/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 2:02 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> When running show job user can see what connectors are in use:
> sqoop:000> show job
> +----+-------------+----------------+--------------+---------+
> | Id | Name | From Connector | To Connector | Enabled |
> +----+-------------+----------------+--------------+---------+
> | 3 | mysql2hdfs2 | 4 | 3 | true |
> | 4 | hdfs2mysql2 | 3 | 4 | true |
> | 1 | mysql2hdfs | 4 | 3 | true |
> | 2 | hdfs2mysql | 3 | 4 | true |
> +----+-------------+----------------+--------------+---------+
> I think that it would be more useful to show the connection instead (or in addition).
>
>
> Diffs
> -----
>
> shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java fab99db
>
> Diff: https://reviews.apache.org/r/34745/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>