You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/31 03:11:00 UTC

[GitHub] [pulsar] Renkai opened a new pull request #9380: Reduce test retry count to zero

Renkai opened a new pull request #9380:
URL: https://github.com/apache/pulsar/pull/9380


   Our current tests will auto-retry failed tests, which could lead to some problems:
   
   * If one method in one test class failed, all methods in the test class will be retriggered, which will make the test easier to timeout and generate more noise logs to make us harder to locate the error log.
   * The failed method may have changed the test environment, and then the second try may report different error info, which will mislead us to solve the problem, too.
   * Auto retry is useful to pass flaky tests, but have a low return on investment for the same reason shown above.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Renkai closed pull request #9380: Reduce test retry count to zero

Posted by GitBox <gi...@apache.org>.
Renkai closed pull request #9380:
URL: https://github.com/apache/pulsar/pull/9380


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Renkai closed pull request #9380: Reduce test retry count to zero

Posted by GitBox <gi...@apache.org>.
Renkai closed pull request #9380:
URL: https://github.com/apache/pulsar/pull/9380


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #9380: Reduce test retry count to zero

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #9380:
URL: https://github.com/apache/pulsar/pull/9380#issuecomment-770369213


   Thanks @Renkai 
   
   I had already files the same patch at #9043 
   
   There is an open discussion.
   Can you please add your opinion in that patch?
   
   I am totally +1 on this patch 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Renkai commented on pull request #9380: Reduce test retry count to zero

Posted by GitBox <gi...@apache.org>.
Renkai commented on pull request #9380:
URL: https://github.com/apache/pulsar/pull/9380#issuecomment-770491471


   @eolivelli Seems set retry count to 0 really have a significant effect on the success rate on our code base, maybe it's not suitable to be merged now, I will leave this patch to see which tests are easy to be flaky


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Renkai commented on pull request #9380: Reduce test retry count to zero

Posted by GitBox <gi...@apache.org>.
Renkai commented on pull request #9380:
URL: https://github.com/apache/pulsar/pull/9380#issuecomment-770320020


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Renkai commented on pull request #9380: Reduce test retry count to zero

Posted by GitBox <gi...@apache.org>.
Renkai commented on pull request #9380:
URL: https://github.com/apache/pulsar/pull/9380#issuecomment-770342702


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org