You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/12/18 11:10:30 UTC

[I] `cargo fmt` doesn't properly work on parquet crate [arrow-rs]

alamb opened a new issue, #6897:
URL: https://github.com/apache/arrow-rs/issues/6897

   Things like https://github.com/apache/arrow-rs/blob/54dccadccc6b599b93a46aef5f03dfd4d9b7349e/parquet/src/lib.rs#L137-L138 cause entire modules to be skipped by `cargo fmt`.  
   
   This means that the parquet code is not properly formatted the way most rust developers would expect
   
   ```shell
   cargo fmt
   ```
   
   @etseidl added commands that do actually format the parquet crate in CI 
   -   [25e1969](https://github.com/apache/arrow-rs/commit/25e196977fd4f2fdd9ad25b3d3936d355ce27d46) / #6328 
   
   However it is confusing to know how to fix CI when it fails. 
   
   I agree the incantation is not desirable, and was meant to be a stop-gap until a better solution can be found.
   
   _Originally posted by @etseidl in https://github.com/apache/arrow-rs/issues/6886#issuecomment-2549995747_
               
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] `cargo fmt` doesn't properly work on parquet crate [arrow-rs]

Posted by "sdf-jkl (via GitHub)" <gi...@apache.org>.

sdf-jkl closed issue #6897: `cargo fmt` doesn't properly work on parquet crate
URL: https://github.com/apache/arrow-rs/issues/6897


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] `cargo fmt` doesn't properly work on parquet crate [arrow-rs]

Posted by "etseidl (via GitHub)" <gi...@apache.org>.

etseidl commented on issue #6897:
URL: https://github.com/apache/arrow-rs/issues/6897#issuecomment-2555845622

   Root cause https://github.com/rust-lang/rustfmt/issues/3253


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org