You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2021/10/08 18:03:58 UTC

[GitHub] [celix] rlenferink commented on a change in pull request #371: Feature/remove psa versions v1

rlenferink commented on a change in pull request #371:
URL: https://github.com/apache/celix/pull/371#discussion_r725207812



##########
File path: bundles/pubsub/examples/CMakeLists.txt
##########
@@ -147,7 +147,7 @@ if (BUILD_PUBSUB_PSA_TCP)
                 Celix::celix_pubsub_serializer_json
                 Celix::celix_pubsub_discovery_etcd
                 Celix::celix_pubsub_topology_manager
-                Celix::celix_pubsub_admin_tcp
+                Celix::celix_pubsub_admin_tcp_v2

Review comment:
       I noticed the directory names are reverted back to their original names (e.g. `pubsub_admin_zmq`, without the `v1` or `v2`). Should that also be done for the target names to possibly remain backwards compatible (I don't know if that's even possible)? Or is this an intentional breaking chance?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org