You are viewing a plain text version of this content. The canonical link for it is here.
Posted to muse-dev@ws.apache.org by "Vinh Nguyen (JIRA)" <ji...@apache.org> on 2007/07/28 04:17:52 UTC
[jira] Created: (MUSE-255) SimpleServiceGroup memory leak, Entry
resources not destroyed properly
SimpleServiceGroup memory leak, Entry resources not destroyed properly
----------------------------------------------------------------------
Key: MUSE-255
URL: https://issues.apache.org/jira/browse/MUSE-255
Project: Muse
Issue Type: Bug
Environment: Muse 2.2.0
Reporter: Vinh Nguyen
Assignee: Dan Jemiolo
In SimpleServiceGroup, resourceAdded() adds new ServiceGroupEntry resources to manage the members. In resourceRemoved(), it removes the Entry resource from the mappings. But it never calls entry.destroy(), so the ResourceManager still holds onto the Entry resources.
The fix should either be in removeEntry() to explicitly call entry.destroy()...or in resourceRemoved() which calls removeEntry().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org
[jira] Updated: (MUSE-255) SimpleServiceGroup memory leak, Entry
resources not destroyed properly
Posted by "Dan Jemiolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MUSE-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Jemiolo updated MUSE-255:
-----------------------------
Component/s: WSRF WSSG ServiceGroup
Fix Version/s: 2.3.0
Affects Version/s: 2.2.0
> SimpleServiceGroup memory leak, Entry resources not destroyed properly
> ----------------------------------------------------------------------
>
> Key: MUSE-255
> URL: https://issues.apache.org/jira/browse/MUSE-255
> Project: Muse
> Issue Type: Bug
> Components: WSRF WSSG ServiceGroup
> Affects Versions: 2.2.0
> Environment: Muse 2.2.0
> Reporter: Vinh Nguyen
> Assignee: Dan Jemiolo
> Fix For: 2.3.0
>
>
> In SimpleServiceGroup, resourceAdded() adds new ServiceGroupEntry resources to manage the members. In resourceRemoved(), it removes the Entry resource from the mappings. But it never calls entry.destroy(), so the ResourceManager still holds onto the Entry resources.
> The fix should either be in removeEntry() to explicitly call entry.destroy()...or in resourceRemoved() which calls removeEntry().
> [VN]:
> The fix is to update resourceRemoved(). Just call entry.shutdown(), which will call removeEntry().
> Don't call entry.shutdown() in removeEntry(), because it'll go into a loop...and removeEntry() will throw an EntryNotFound error because the entry doens't exist anymore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org
RE: [jira] Commented: (MUSE-255) SimpleServiceGroup memory leak, Entry resources not destroyed properly
Posted by "Vinh Nguyen (vinguye2)" <vi...@cisco.com>.
Hi Dan,
Yep, I already have the fix locally in my code, and it works properly.
I have a SG which automatically picks up resources which I dynamically
create at runtime. When these resources terminate, the SG drops them
from its entry list, so they are no longer accessible via the SG. I
will try to test your latest Muse updates sometime soon.
-Vinh
-----Original Message-----
From: Dan Jemiolo (JIRA) [mailto:jira@apache.org]
Sent: Sunday, September 02, 2007 9:59 AM
To: muse-dev@ws.apache.org
Subject: [jira] Commented: (MUSE-255) SimpleServiceGroup memory leak,
Entry resources not destroyed properly
[
https://issues.apache.org/jira/browse/MUSE-255?page=com.atlassian.jira.p
lugin.system.issuetabpanels:comment-tabpanel#action_12524368 ]
Dan Jemiolo commented on MUSE-255:
----------------------------------
I added the suggested fix... let me know if this works for you.
> SimpleServiceGroup memory leak, Entry resources not destroyed properly
> ----------------------------------------------------------------------
>
> Key: MUSE-255
> URL: https://issues.apache.org/jira/browse/MUSE-255
> Project: Muse
> Issue Type: Bug
> Components: WSRF WSSG ServiceGroup
> Affects Versions: 2.2.0
> Environment: Muse 2.2.0
> Reporter: Vinh Nguyen
> Assignee: Dan Jemiolo
> Fix For: 2.3.0
>
>
> In SimpleServiceGroup, resourceAdded() adds new ServiceGroupEntry
resources to manage the members. In resourceRemoved(), it removes the
Entry resource from the mappings. But it never calls entry.destroy(),
so the ResourceManager still holds onto the Entry resources.
> The fix should either be in removeEntry() to explicitly call
entry.destroy()...or in resourceRemoved() which calls removeEntry().
> [VN]:
> The fix is to update resourceRemoved(). Just call entry.shutdown(),
which will call removeEntry().
> Don't call entry.shutdown() in removeEntry(), because it'll go into a
loop...and removeEntry() will throw an EntryNotFound error because the
entry doens't exist anymore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org
[jira] Commented: (MUSE-255) SimpleServiceGroup memory leak, Entry
resources not destroyed properly
Posted by "Dan Jemiolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MUSE-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524368 ]
Dan Jemiolo commented on MUSE-255:
----------------------------------
I added the suggested fix... let me know if this works for you.
> SimpleServiceGroup memory leak, Entry resources not destroyed properly
> ----------------------------------------------------------------------
>
> Key: MUSE-255
> URL: https://issues.apache.org/jira/browse/MUSE-255
> Project: Muse
> Issue Type: Bug
> Components: WSRF WSSG ServiceGroup
> Affects Versions: 2.2.0
> Environment: Muse 2.2.0
> Reporter: Vinh Nguyen
> Assignee: Dan Jemiolo
> Fix For: 2.3.0
>
>
> In SimpleServiceGroup, resourceAdded() adds new ServiceGroupEntry resources to manage the members. In resourceRemoved(), it removes the Entry resource from the mappings. But it never calls entry.destroy(), so the ResourceManager still holds onto the Entry resources.
> The fix should either be in removeEntry() to explicitly call entry.destroy()...or in resourceRemoved() which calls removeEntry().
> [VN]:
> The fix is to update resourceRemoved(). Just call entry.shutdown(), which will call removeEntry().
> Don't call entry.shutdown() in removeEntry(), because it'll go into a loop...and removeEntry() will throw an EntryNotFound error because the entry doens't exist anymore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org
[jira] Updated: (MUSE-255) SimpleServiceGroup memory leak, Entry
resources not destroyed properly
Posted by "Vinh Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MUSE-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinh Nguyen updated MUSE-255:
-----------------------------
Description:
In SimpleServiceGroup, resourceAdded() adds new ServiceGroupEntry resources to manage the members. In resourceRemoved(), it removes the Entry resource from the mappings. But it never calls entry.destroy(), so the ResourceManager still holds onto the Entry resources.
The fix should either be in removeEntry() to explicitly call entry.destroy()...or in resourceRemoved() which calls removeEntry().
[VN]:
The fix is to update resourceRemoved(). Just call entry.shutdown(), which will call removeEntry().
Don't call entry.shutdown() in removeEntry(), because it'll go into a loop...and removeEntry() will throw an EntryNotFound error because the entry doens't exist anymore.
was:
In SimpleServiceGroup, resourceAdded() adds new ServiceGroupEntry resources to manage the members. In resourceRemoved(), it removes the Entry resource from the mappings. But it never calls entry.destroy(), so the ResourceManager still holds onto the Entry resources.
The fix should either be in removeEntry() to explicitly call entry.destroy()...or in resourceRemoved() which calls removeEntry().
Added the proper fix.
> SimpleServiceGroup memory leak, Entry resources not destroyed properly
> ----------------------------------------------------------------------
>
> Key: MUSE-255
> URL: https://issues.apache.org/jira/browse/MUSE-255
> Project: Muse
> Issue Type: Bug
> Environment: Muse 2.2.0
> Reporter: Vinh Nguyen
> Assignee: Dan Jemiolo
>
> In SimpleServiceGroup, resourceAdded() adds new ServiceGroupEntry resources to manage the members. In resourceRemoved(), it removes the Entry resource from the mappings. But it never calls entry.destroy(), so the ResourceManager still holds onto the Entry resources.
> The fix should either be in removeEntry() to explicitly call entry.destroy()...or in resourceRemoved() which calls removeEntry().
> [VN]:
> The fix is to update resourceRemoved(). Just call entry.shutdown(), which will call removeEntry().
> Don't call entry.shutdown() in removeEntry(), because it'll go into a loop...and removeEntry() will throw an EntryNotFound error because the entry doens't exist anymore.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org