You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/11/16 14:00:49 UTC

[GitHub] dlamblin edited a comment on issue #4182: [AIRFLOW-3336] Add new TriggerRule that will consider skipped ancestors as success

dlamblin edited a comment on issue #4182: [AIRFLOW-3336] Add new TriggerRule that will consider skipped ancestors as success 
URL: https://github.com/apache/incubator-airflow/pull/4182#issuecomment-439398830
 
 
   The name of the trigger rule is unlike the other two word rules… I would opt for something like `none_failed`.
   When I look at [the rst](https://github.com/apache/incubator-airflow/blob/dfacbf6d89b65a6d3f07da7722b64e0385d06e9e/docs/concepts.rst#trigger-rules) in GitHub the ``upstream_failed`` does not render right, but I don't know why, or whether it would be an issue for the docs.
   Otherwise this looks pretty good; would adding a dummy op with this rule to the `example_short_circuit_operator.py` make sense?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services