You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/13 09:25:51 UTC
[GitHub] [flink] MartijnVisser opened a new pull request, #21049: [FLINK-29626][Runtime] Update Akka to 2.6.20
MartijnVisser opened a new pull request, #21049:
URL: https://github.com/apache/flink/pull/21049
## What is the purpose of the change
* Update Akka to the latest 2.6 patch version, which is still under Apache license
## Brief change log
* Updated POM and NOTICE files
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a diff in pull request #21049: [FLINK-29626][Runtime] Update Akka to 2.6.20
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #21049:
URL: https://github.com/apache/flink/pull/21049#discussion_r1000469655
##########
flink-rpc/flink-rpc-akka/pom.xml:
##########
@@ -195,6 +201,17 @@ under the License.
<exclude>META-INF/NOTICE.txt</exclude>
</excludes>
</filter>
+ <filter>
+ <artifact>*:*</artifact>
+ <excludes>
+ <!-- Only some of these licenses actually apply to the JAR and have been manually
+ placed in this module's resources directory. -->
+ <exclude>LICENSE</exclude>
+ <!-- Only parts of NOTICE file actually apply to the netty JAR and have been manually
+ copied into this modules's NOTICE file. -->
+ <exclude>NOTICE</exclude>
+ </excludes>
Review Comment:
This needs a second check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #21049: [FLINK-29626][Runtime] Update Akka to 2.6.20
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21049:
URL: https://github.com/apache/flink/pull/21049#issuecomment-1283670806
> Does this imply that this won't work with Flink?
It implies that we should bump the Scala version in flink-rpc-akka.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #21049: [FLINK-29626][Runtime] Update Akka to 2.6.20
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21049:
URL: https://github.com/apache/flink/pull/21049#discussion_r994587465
##########
flink-rpc/flink-rpc-akka/src/main/resources/META-INF/NOTICE:
##########
@@ -9,12 +9,12 @@ This project bundles the following dependencies under the Apache Software Licens
- com.hierynomus:asn-one:0.5.0
- com.typesafe:config:1.4.0
Review Comment:
```suggestion
- com.typesafe:config:1.4.2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #21049: [FLINK-29626][Runtime] Update Akka to 2.6.20
Posted by GitBox <gi...@apache.org>.
zentol merged PR #21049:
URL: https://github.com/apache/flink/pull/21049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #21049: [FLINK-29626][Runtime] Update Akka to 2.6.20
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21049:
URL: https://github.com/apache/flink/pull/21049#discussion_r994588146
##########
flink-rpc/flink-rpc-akka/src/main/resources/META-INF/NOTICE:
##########
@@ -7,14 +7,14 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
- com.hierynomus:asn-one:0.5.0
-- com.typesafe:config:1.4.0
-- com.typesafe:ssl-config-core_2.12:0.4.2
-- com.typesafe.akka:akka-actor_2.12:2.6.15
-- com.typesafe.akka:akka-remote_2.12:2.6.15
-- com.typesafe.akka:akka-pki_2.12:2.6.15
-- com.typesafe.akka:akka-protobuf-v3_2.12:2.6.15
-- com.typesafe.akka:akka-slf4j_2.12:2.6.15
-- com.typesafe.akka:akka-stream_2.12:2.6.15
+- com.typesafe:config:1.4.2
+- com.typesafe:ssl-config-core_2.12:0.4.3
+- com.typesafe.akka:akka-actor_2.12:2.6.20
+- com.typesafe.akka:akka-remote_2.12:2.6.20
+- com.typesafe.akka:akka-pki_2.12:2.6.20
+- com.typesafe.akka:akka-protobuf-v3_2.12:2.6.20
+- com.typesafe.akka:akka-slf4j_2.12:2.6.20
+- com.typesafe.akka:akka-stream_2.12:2.6.20
- io.netty:netty:3.10.6.Final
- org.agrona:agrona:1.9.0
Review Comment:
```suggestion
- org.agrona:agrona:1.15.1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #21049: [FLINK-29626][Runtime] Update Akka to 2.6.20
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21049:
URL: https://github.com/apache/flink/pull/21049#issuecomment-1277541778
- 2.19 bumped the scala dependency to 2.12.16
- it's possible we no longer ship scala-parser-combinators_2.12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #21049: [FLINK-29626][Runtime] Update Akka to 2.6.20
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21049:
URL: https://github.com/apache/flink/pull/21049#discussion_r1000737949
##########
flink-rpc/flink-rpc-akka/pom.xml:
##########
@@ -195,6 +201,17 @@ under the License.
<exclude>META-INF/NOTICE.txt</exclude>
</excludes>
</filter>
+ <filter>
+ <artifact>*:*</artifact>
+ <excludes>
+ <!-- Only some of these licenses actually apply to the JAR and have been manually
+ placed in this module's resources directory. -->
+ <exclude>LICENSE</exclude>
+ <!-- Only parts of NOTICE file actually apply to the netty JAR and have been manually
+ copied into this modules's NOTICE file. -->
+ <exclude>NOTICE</exclude>
+ </excludes>
Review Comment:
We shouldn't apply such a blanket filter, but scope it to specific dependencies.
Did you check the NOTICE/LICENSE contents for whether everything applicable is replicated in our license files?
##########
flink-rpc/flink-rpc-akka/pom.xml:
##########
@@ -195,6 +201,17 @@ under the License.
<exclude>META-INF/NOTICE.txt</exclude>
</excludes>
</filter>
+ <filter>
+ <artifact>*:*</artifact>
+ <excludes>
+ <!-- Only some of these licenses actually apply to the JAR and have been manually
+ placed in this module's resources directory. -->
+ <exclude>LICENSE</exclude>
+ <!-- Only parts of NOTICE file actually apply to the netty JAR and have been manually
+ copied into this modules's NOTICE file. -->
+ <exclude>NOTICE</exclude>
+ </excludes>
Review Comment:
We shouldn't apply such a generic filter, but scope it to specific dependencies.
Did you check the NOTICE/LICENSE contents for whether everything applicable is replicated in our license files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21049: [FLINK-29626][Runtime] Update Akka to 2.6.20
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21049:
URL: https://github.com/apache/flink/pull/21049#issuecomment-1277311447
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "862f866ab2dca08ecf92a4c90f4fddc884bf4327",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "862f866ab2dca08ecf92a4c90f4fddc884bf4327",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 862f866ab2dca08ecf92a4c90f4fddc884bf4327 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a diff in pull request #21049: [FLINK-29626][Runtime] Update Akka to 2.6.20
Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #21049:
URL: https://github.com/apache/flink/pull/21049#discussion_r994587831
##########
flink-rpc/flink-rpc-akka/src/main/resources/META-INF/NOTICE:
##########
@@ -7,14 +7,14 @@ The Apache Software Foundation (http://www.apache.org/).
This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
- com.hierynomus:asn-one:0.5.0
-- com.typesafe:config:1.4.0
+- com.typesafe:config:1.4.2
- com.typesafe:ssl-config-core_2.12:0.4.2
Review Comment:
```suggestion
- com.typesafe:ssl-config-core_2.12:0.4.3
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21049: [FLINK-29626][Runtime] Update Akka to 2.6.20
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21049:
URL: https://github.com/apache/flink/pull/21049#issuecomment-1282087554
> * 2.20 bumped the scala dependency to 2.12.16
Does this imply that this won't work with Flink?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org