[GitHub] sdedic commented on issue #361: my first refactoring session

[GitBox <gi...@apache.org>]

sdedic commented on issue #361: my first refactoring session
URL: https://github.com/apache/incubator-netbeans/pull/361#issuecomment-357458449
 
 
   Keep in mind that usage of Lambda expression also totally breaks fix-and-continue during debugging. It's a nice syntax suggar but until Hotspot folks fix the VM, class with lambdas does not allow to incrementally fix the code.
   
   As for unit tests: they run on the master. So the only sane approach is to fix the code so that tests run again. But this PR is WIP, so OK. But before the PR is reviewed, I recommend to discard that commit from history.
   
   The PR starts being hard to read, mixing (intentionally just) formatting changes with refactorings which actually have potential to break something. I recommend to separate those two actions into either separate commits, or separate PRs - it's easier to verify that refactoring did not change semantic if 90% of file is not whitespace-changed.
   
   As for commit messages (personal opinion): I will not approve PR with messages like "for the queen", "fixing errors" (which actually deletes test code), or "order of maw". I believe that added confusion which outweights the fun of reading them.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists