You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ar...@apache.org on 2021/06/26 05:58:46 UTC

[flink] branch release-1.13 updated: [FLINK-22492][test] Use order-agnostic check in KinesisTableApiITCase.

This is an automated email from the ASF dual-hosted git repository.

arvid pushed a commit to branch release-1.13
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/release-1.13 by this push:
     new b068623  [FLINK-22492][test] Use order-agnostic check in KinesisTableApiITCase.
b068623 is described below

commit b06862333119359afba6a8f43ed08a55a7c7e57b
Author: Arvid Heise <ar...@ververica.com>
AuthorDate: Thu Jun 24 11:02:39 2021 +0200

    [FLINK-22492][test] Use order-agnostic check in KinesisTableApiITCase.
    
    The query doesn't impose any ordering and a reorder may happen as is.
---
 .../apache/flink/streaming/kinesis/test/KinesisTableApiITCase.java  | 6 ++++--
 .../java/org/apache/flink/streaming/kinesis/test/model/Order.java   | 5 +++++
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/flink-end-to-end-tests/flink-streaming-kinesis-test/src/test/java/org/apache/flink/streaming/kinesis/test/KinesisTableApiITCase.java b/flink-end-to-end-tests/flink-streaming-kinesis-test/src/test/java/org/apache/flink/streaming/kinesis/test/KinesisTableApiITCase.java
index 5256a50..b86999b 100644
--- a/flink-end-to-end-tests/flink-streaming-kinesis-test/src/test/java/org/apache/flink/streaming/kinesis/test/KinesisTableApiITCase.java
+++ b/flink-end-to-end-tests/flink-streaming-kinesis-test/src/test/java/org/apache/flink/streaming/kinesis/test/KinesisTableApiITCase.java
@@ -32,6 +32,7 @@ import org.apache.flink.shaded.guava18.com.google.common.collect.ImmutableList;
 
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
+import org.hamcrest.Matchers;
 import org.junit.Before;
 import org.junit.ClassRule;
 import org.junit.Test;
@@ -49,7 +50,7 @@ import java.util.Properties;
 import java.util.concurrent.TimeUnit;
 import java.util.stream.Collectors;
 
-import static org.junit.Assert.assertEquals;
+import static org.hamcrest.MatcherAssert.assertThat;
 
 /** End-to-end test for Kinesis Table API using Kinesalite. */
 @Category(value = {TravisGroup1.class})
@@ -107,8 +108,9 @@ public class KinesisTableApiITCase extends TestLogger {
 
         executeSqlStatements(readSqlFile("filter-large-orders.sql"));
 
+        // result order is not guaranteed
         List<Order> result = readAllOrdersFromKinesis(kinesisClient);
-        assertEquals(expected, result);
+        assertThat(result, Matchers.containsInAnyOrder(expected.toArray(new Order[0])));
     }
 
     private List<Order> readAllOrdersFromKinesis(final KinesisPubsubClient client)
diff --git a/flink-end-to-end-tests/flink-streaming-kinesis-test/src/test/java/org/apache/flink/streaming/kinesis/test/model/Order.java b/flink-end-to-end-tests/flink-streaming-kinesis-test/src/test/java/org/apache/flink/streaming/kinesis/test/model/Order.java
index b6bb8b7..15c158c 100644
--- a/flink-end-to-end-tests/flink-streaming-kinesis-test/src/test/java/org/apache/flink/streaming/kinesis/test/model/Order.java
+++ b/flink-end-to-end-tests/flink-streaming-kinesis-test/src/test/java/org/apache/flink/streaming/kinesis/test/model/Order.java
@@ -57,4 +57,9 @@ public class Order {
     public int hashCode() {
         return Objects.hash(code, quantity);
     }
+
+    @Override
+    public String toString() {
+        return "Order{" + "code='" + code + '\'' + ", quantity=" + quantity + '}';
+    }
 }