You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jason Fehr (Code Review)" <ge...@cloudera.org> on 2026/09/08 18:44:47 UTC
[Impala-ASF-CR] IMPALA-14752: Support W3C trace context propagation for hs2-http
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24706 )
Change subject: IMPALA-14752: Support W3C trace context propagation for hs2-http
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/24706/2/be/src/observe/otel-trace-manager.cc
File be/src/observe/otel-trace-manager.cc:
http://gerrit.cloudera.org:8080/#/c/24706/2/be/src/observe/otel-trace-manager.cc@186
PS2, Line 186: if (!http_traceparent.empty()) {
> Done
Done
http://gerrit.cloudera.org:8080/#/c/24706/3/be/src/observe/otel-trace-manager.cc
File be/src/observe/otel-trace-manager.cc:
http://gerrit.cloudera.org:8080/#/c/24706/3/be/src/observe/otel-trace-manager.cc@196
PS3, Line 196: LOG(WARNING) << "Invalid traceparent header value for query_id='" << query_id_
Nit: The issue could also be in the tracestate header, it should be included in this error message and the message made more generic.
--
To view, visit http://gerrit.cloudera.org:8080/24706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieac548f4f5f613ba116d1a79d95e31b7a1a37b97
Gerrit-Change-Number: 24706
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Sep 2026 18:44:47 +0000
Gerrit-HasComments: Yes