You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "cmcfarlen (via GitHub)" <gi...@apache.org> on 2025/11/19 16:21:46 UTC
[PR] Require and call destructors on ClassAllocated objects [trafficserver]
cmcfarlen opened a new pull request, #12676:
URL: https://github.com/apache/trafficserver/pull/12676
This removes the flag to call the destructor on ClassAllocator objects. ClassAllocator now requires that objects have a noexcept destructor that it can call on all objects. This is much safer than the explicit flag and should not add any overhead for trivially destructed types. I've added unit tests for this and also ran ASAN to make sure that the tests don't report memory leaks.
The unit tests were written by Claude, other code is my own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require and call destructors on ClassAllocated objects [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #12676:
URL: https://github.com/apache/trafficserver/pull/12676#issuecomment-3553718518
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require and call destructors on ClassAllocated objects [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #12676:
URL: https://github.com/apache/trafficserver/pull/12676#issuecomment-3553719480
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require and call destructors on ClassAllocated objects [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen merged PR #12676:
URL: https://github.com/apache/trafficserver/pull/12676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require and call destructors on ClassAllocated objects [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #12676:
URL: https://github.com/apache/trafficserver/pull/12676#discussion_r2582679138
##########
src/proxy/http/HttpSM.cc:
##########
@@ -280,7 +277,6 @@ HttpSM::cleanup()
void
HttpSM::destroy()
{
- cleanup();
Review Comment:
Nice cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Require and call destructors on ClassAllocated objects [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #12676:
URL: https://github.com/apache/trafficserver/pull/12676#issuecomment-3572061609
[approve ci ubuntu rocky]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org