[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1481: MINIFICPP-1948 Add the UUID to the end of Processor and Controller Service log lines

[GitBox <gi...@apache.org>]

szaszm commented on code in PR #1481:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1481#discussion_r1053362619


##########
libminifi/include/core/logging/LoggerConfiguration.h:
##########
@@ -133,16 +132,21 @@ class LoggerConfiguration {
 
   class LoggerImpl : public Logger {
    public:
-    explicit LoggerImpl(std::string name, const std::shared_ptr<LoggerControl> &controller, const std::shared_ptr<spdlog::logger> &delegate)
+    explicit LoggerImpl(std::string name, std::optional<std::string> id, const std::shared_ptr<LoggerControl> &controller, const std::shared_ptr<spdlog::logger> &delegate)

Review Comment:
   Do you think we can pass an `Identifier` instead? It's cheaper to copy, and we can still format it appropriately before storing it in the string member.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org