You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "skymilong (via GitHub)" <gi...@apache.org> on 2024/03/28 04:01:33 UTC

[I] [Bug] Discrepancy Between Code and Comments in `getBackends` Method Impacts Other Connectors [doris]

skymilong opened a new issue, #32947:
URL: https://github.com/apache/doris/issues/32947

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Version
   
   Last code from the master branch (as of 2024-3-28 11:53:44)
   
   ### What's Wrong?
   
   There is an inconsistency between the comments and the code logic in the `getBackends` method. The comments mention that this interface will not verify user permissions, but in the code, I see a line `executeCheckPassword(request, response);`, which seems to perform permission verification. Looking further into the `executeCheckPassword` method, it calls `getAuthorizationInfo`, and `getAuthorizationInfo` returns false when the "Authorization" header information is empty. This results in the `executeCheckPassword` method throwing an `UnauthorizedException` exception.This results in the `executeCheckPassword` method throwing an `UnauthorizedException` exception. This issue has impacted the access of other connectors, in my case, I'm using flink-cdc 3.0.1.
   
   ### What You Expected?
   
   I expect the behavior of the code to be consistent with the comments. If the comments indicate that there will be no permission verification, then there should be no operation for permission verification in the code.
   
   ### How to Reproduce?
   
   here https://github.com/apache/doris/blob/2a82bb7e0d52f4901f45bf646a904bf8a3c2dad8/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/BackendsAction.java#L74
   
   ### Anything Else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [I] [Bug] Discrepancy Between Code and Comments in `getBackends` Method Impacts Other Connectors [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman closed issue #32947: [Bug] Discrepancy Between Code and Comments in `getBackends` Method Impacts Other Connectors
URL: https://github.com/apache/doris/issues/32947


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [I] [Bug] Discrepancy Between Code and Comments in `getBackends` Method Impacts Other Connectors [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #32947:
URL: https://github.com/apache/doris/issues/32947#issuecomment-3288991476

   We're closing this issue because it hasn't been updated in a while.
   If you'd like to revive this issue, please reopen it and feel free a maintainer to remove the Stale tag!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org