[GitHub] [tvm] driazati commented on a diff in pull request #13518: [microTVM][Arduino]Add `serial_number` to project options and tests

[GitBox <gi...@apache.org>]

driazati commented on code in PR #13518:
URL: https://github.com/apache/tvm/pull/13518#discussion_r1037705898


##########
apps/microtvm/arduino/template_project/microtvm_api_server.py:
##########
@@ -594,21 +622,24 @@ def flash(self, options):
             )
 
     def open_transport(self, options):
+        # TODO: This is to avoid breaking GPU docker on running the tutorials.
         import serial
         import serial.tools.list_ports

Review Comment:
   if this file is imported but this function isn't run during the tutorial docs build then it would fail, this fixes it with a lazy import. it would be nice to link to an issue about this though for more context



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org