You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/02/11 09:08:15 UTC
[GitHub] [servicecomb-kie] GuoYL123 opened a new pull request #91: #78 #80
add status and create/update time
GuoYL123 opened a new pull request #91: #78 #80 add status and create/update time
URL: https://github.com/apache/servicecomb-kie/pull/91
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang merged pull request #91: #78 #80
add status and create/update time
Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #91: #78 #80 add status and create/update time
URL: https://github.com/apache/servicecomb-kie/pull/91
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #91: #78 #80 add status and create/update time
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #91: #78 #80 add status and create/update time
URL: https://github.com/apache/servicecomb-kie/pull/91#discussion_r377531176
##########
File path: server/resource/v1/common.go
##########
@@ -200,8 +198,19 @@ func checkPagination(limitStr, offsetStr string) (int64, int64, error) {
}
return limit, offset, err
}
+
+func checkStatus(status string) (string, error) {
+ var err error
+ if status != "" {
+ if status != common.Enabled && status != common.Disabled {
+ return "", err
Review comment:
这个err没有定义
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #91: #78 #80 add status and create/update time
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #91: #78 #80 add status and create/update time
URL: https://github.com/apache/servicecomb-kie/pull/91#discussion_r377529814
##########
File path: pkg/common/common.go
##########
@@ -46,9 +46,11 @@ const (
ContentTypeYaml = "text/yaml"
)
-//const for server/resource/v1
+//const of server
const (
PatternExact = "exact"
+ Enabled = "enabled"
Review comment:
加个前缀Status
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services