You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Alan Parkinson (JIRA)" <ji...@codehaus.org> on 2011/05/16 00:32:22 UTC
[jira] Created: (MCHANGES-245) Custom mapping of IMS issue types to
action types for announcements
Custom mapping of IMS issue types to action types for announcements
-------------------------------------------------------------------
Key: MCHANGES-245
URL: http://jira.codehaus.org/browse/MCHANGES-245
Project: Maven 2.x Changes Plugin
Issue Type: New Feature
Components: announcement
Affects Versions: 2.4
Reporter: Alan Parkinson
The current version only maps "Bug", "New Feature" and "Improvement" issues types to "fix", "add" and "update" actions. If the issue type from the IMS isn't recognized the default action type is blank and this leads to the issue not being included within the announcement when using the default template.
This set of supported issue types can be limiting with a modern JIRA installation as is it has a greater range of issue types and can be extended with additional types. The most flexible solution for JIRA and other IMSes would be to allow the the mapping of issue types to action types.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-245) Custom mapping of IMS issue types
to action types for announcements
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=269557#action_269557 ]
Dennis Lundberg commented on MCHANGES-245:
------------------------------------------
Alan and Benson,
I'm not feeling comfortable with the patch that was applied for a couple of reasons.
* The new parameter in AnnouncementMojo.java needs an example of how one would configure the plugin to add mappings.
* The changes to IssueAdapter is not the right way to go. We need to figure out a way to extract the mapping (default values and such) to a class for a specific IMS. This patch exposes the current (not so good) implementation, by adding new public methods. Instead we should create a JIRAAdapter or something similar that can create a mapping Map, which can be used as an input parameter for the IssueAdapter class.
For the last two releases of the plugin I've been working to try to abstract away the IMS implementation details as much as possible into helper classes and adapters. The goal is to eventually create an IMS API. Therefor I review every change with that in mind.
> Custom mapping of IMS issue types to action types for announcements
> -------------------------------------------------------------------
>
> Key: MCHANGES-245
> URL: http://jira.codehaus.org/browse/MCHANGES-245
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Affects Versions: 2.4
> Reporter: Alan Parkinson
> Fix For: 2.6
>
> Attachments: MCHANGES-245-maven-changes-plugin.patch
>
>
> The current version only maps "Bug", "New Feature" and "Improvement" issues types to "fix", "add" and "update" actions. If the issue type from the IMS isn't recognized the default action type is blank and this leads to the issue not being included within the announcement when using the default template.
> This set of supported issue types can be limiting with a modern JIRA installation as is it has a greater range of issue types and can be extended with additional types. The most flexible solution for JIRA and other IMSes would be to allow the the mapping of issue types to action types.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-245) Custom mapping of IMS issue types
to action types for announcements
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=269591#action_269591 ]
Benson Margulies commented on MCHANGES-245:
-------------------------------------------
Dennis,
As the code currently stands, it's impossible to even use the plugin with a copy of JIRA that has some mild customization, let alone other IMSes. I think that the end-user value of this functionality is valuable enough to keep this and then fix the modularity. After all, 'public' doesn't mean very much in a plugin.
I'm happy to go take a run at the modularity and see if I can do some abstraction along those lines.
--benson
> Custom mapping of IMS issue types to action types for announcements
> -------------------------------------------------------------------
>
> Key: MCHANGES-245
> URL: http://jira.codehaus.org/browse/MCHANGES-245
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Affects Versions: 2.4
> Reporter: Alan Parkinson
> Fix For: 2.6
>
> Attachments: MCHANGES-245-maven-changes-plugin.patch
>
>
> The current version only maps "Bug", "New Feature" and "Improvement" issues types to "fix", "add" and "update" actions. If the issue type from the IMS isn't recognized the default action type is blank and this leads to the issue not being included within the announcement when using the default template.
> This set of supported issue types can be limiting with a modern JIRA installation as is it has a greater range of issue types and can be extended with additional types. The most flexible solution for JIRA and other IMSes would be to allow the the mapping of issue types to action types.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MCHANGES-245) Custom mapping of IMS issue types to
action types for announcements
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies closed MCHANGES-245.
-------------------------------------
Resolution: Fixed
Modularity a-la-Dennis done.
> Custom mapping of IMS issue types to action types for announcements
> -------------------------------------------------------------------
>
> Key: MCHANGES-245
> URL: http://jira.codehaus.org/browse/MCHANGES-245
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Affects Versions: 2.4
> Reporter: Alan Parkinson
> Assignee: Benson Margulies
> Fix For: 2.6
>
> Attachments: MCHANGES-245-maven-changes-plugin.patch
>
>
> The current version only maps "Bug", "New Feature" and "Improvement" issues types to "fix", "add" and "update" actions. If the issue type from the IMS isn't recognized the default action type is blank and this leads to the issue not being included within the announcement when using the default template.
> This set of supported issue types can be limiting with a modern JIRA installation as is it has a greater range of issue types and can be extended with additional types. The most flexible solution for JIRA and other IMSes would be to allow the the mapping of issue types to action types.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHANGES-245) Custom mapping of IMS issue types to
action types for announcements
Posted by "Alan Parkinson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Parkinson updated MCHANGES-245:
------------------------------------
Attachment: MCHANGES-245-maven-changes-plugin.patch
I have created a possible solution to the ticket based on adding a new configuration parameter "issueTypes". The parameter is a map that takes the action type as the key and the value as a comma separated string of issue types e.g.
<issueTypes>
<add>New Feature, Story, Epic</add>
</issueTypes>
If action type is not defined in the map (The example doesn't defined "fix" or "update") the default issue types are used for the undefined action types.
> Custom mapping of IMS issue types to action types for announcements
> -------------------------------------------------------------------
>
> Key: MCHANGES-245
> URL: http://jira.codehaus.org/browse/MCHANGES-245
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Affects Versions: 2.4
> Reporter: Alan Parkinson
> Attachments: MCHANGES-245-maven-changes-plugin.patch
>
>
> The current version only maps "Bug", "New Feature" and "Improvement" issues types to "fix", "add" and "update" actions. If the issue type from the IMS isn't recognized the default action type is blank and this leads to the issue not being included within the announcement when using the default template.
> This set of supported issue types can be limiting with a modern JIRA installation as is it has a greater range of issue types and can be extended with additional types. The most flexible solution for JIRA and other IMSes would be to allow the the mapping of issue types to action types.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MCHANGES-245) Custom mapping of IMS issue types to
action types for announcements
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies closed MCHANGES-245.
-------------------------------------
Resolution: Fixed
Fix Version/s: 2.6
Patch applied rev 1131456. Thanks.
> Custom mapping of IMS issue types to action types for announcements
> -------------------------------------------------------------------
>
> Key: MCHANGES-245
> URL: http://jira.codehaus.org/browse/MCHANGES-245
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Affects Versions: 2.4
> Reporter: Alan Parkinson
> Fix For: 2.6
>
> Attachments: MCHANGES-245-maven-changes-plugin.patch
>
>
> The current version only maps "Bug", "New Feature" and "Improvement" issues types to "fix", "add" and "update" actions. If the issue type from the IMS isn't recognized the default action type is blank and this leads to the issue not being included within the announcement when using the default template.
> This set of supported issue types can be limiting with a modern JIRA installation as is it has a greater range of issue types and can be extended with additional types. The most flexible solution for JIRA and other IMSes would be to allow the the mapping of issue types to action types.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-245) Custom mapping of IMS issue types
to action types for announcements
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=269595#action_269595 ]
Benson Margulies commented on MCHANGES-245:
-------------------------------------------
Also rev r1131497.
> Custom mapping of IMS issue types to action types for announcements
> -------------------------------------------------------------------
>
> Key: MCHANGES-245
> URL: http://jira.codehaus.org/browse/MCHANGES-245
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Affects Versions: 2.4
> Reporter: Alan Parkinson
> Assignee: Benson Margulies
> Fix For: 2.6
>
> Attachments: MCHANGES-245-maven-changes-plugin.patch
>
>
> The current version only maps "Bug", "New Feature" and "Improvement" issues types to "fix", "add" and "update" actions. If the issue type from the IMS isn't recognized the default action type is blank and this leads to the issue not being included within the announcement when using the default template.
> This set of supported issue types can be limiting with a modern JIRA installation as is it has a greater range of issue types and can be extended with additional types. The most flexible solution for JIRA and other IMSes would be to allow the the mapping of issue types to action types.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-245) Custom mapping of IMS issue types
to action types for announcements
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=269596#action_269596 ]
Benson Margulies commented on MCHANGES-245:
-------------------------------------------
r1132453 | bimargulies | 2011-06-05 12:36:50 -0400 (Sun, 05 Jun 2011) | 1 line
[MCHANGES-245]: add more documwntation for new issueTypes parameter on announcements
------------------------------------------------------------------------
> Custom mapping of IMS issue types to action types for announcements
> -------------------------------------------------------------------
>
> Key: MCHANGES-245
> URL: http://jira.codehaus.org/browse/MCHANGES-245
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Affects Versions: 2.4
> Reporter: Alan Parkinson
> Assignee: Benson Margulies
> Fix For: 2.6
>
> Attachments: MCHANGES-245-maven-changes-plugin.patch
>
>
> The current version only maps "Bug", "New Feature" and "Improvement" issues types to "fix", "add" and "update" actions. If the issue type from the IMS isn't recognized the default action type is blank and this leads to the issue not being included within the announcement when using the default template.
> This set of supported issue types can be limiting with a modern JIRA installation as is it has a greater range of issue types and can be extended with additional types. The most flexible solution for JIRA and other IMSes would be to allow the the mapping of issue types to action types.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHANGES-245) Custom mapping of IMS issue types
to action types for announcements
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=270485#comment-270485 ]
Dennis Lundberg commented on MCHANGES-245:
------------------------------------------
Now that the modularity and documentation is in place I think we can close this issue.
> Custom mapping of IMS issue types to action types for announcements
> -------------------------------------------------------------------
>
> Key: MCHANGES-245
> URL: http://jira.codehaus.org/browse/MCHANGES-245
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Affects Versions: 2.4
> Reporter: Alan Parkinson
> Assignee: Benson Margulies
> Fix For: 2.6
>
> Attachments: MCHANGES-245-maven-changes-plugin.patch
>
>
> The current version only maps "Bug", "New Feature" and "Improvement" issues types to "fix", "add" and "update" actions. If the issue type from the IMS isn't recognized the default action type is blank and this leads to the issue not being included within the announcement when using the default template.
> This set of supported issue types can be limiting with a modern JIRA installation as is it has a greater range of issue types and can be extended with additional types. The most flexible solution for JIRA and other IMSes would be to allow the the mapping of issue types to action types.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MCHANGES-245) Custom mapping of IMS
issue types to action types for announcements
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=269551#action_269551 ]
Benson Margulies edited comment on MCHANGES-245 at 6/5/11 11:09 AM:
--------------------------------------------------------------------
Patch applied rev 1131456. Thanks.
r1131456 | bimargulies | 2011-06-04 14:13:08 -0400 (Sat, 04 Jun 2011) | 1 line
[MCHANGES-245]: customization of issue types (from Alan Parkinson)
was (Author: bmargulies):
Patch applied rev 1131456. Thanks.
> Custom mapping of IMS issue types to action types for announcements
> -------------------------------------------------------------------
>
> Key: MCHANGES-245
> URL: http://jira.codehaus.org/browse/MCHANGES-245
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Affects Versions: 2.4
> Reporter: Alan Parkinson
> Assignee: Benson Margulies
> Fix For: 2.6
>
> Attachments: MCHANGES-245-maven-changes-plugin.patch
>
>
> The current version only maps "Bug", "New Feature" and "Improvement" issues types to "fix", "add" and "update" actions. If the issue type from the IMS isn't recognized the default action type is blank and this leads to the issue not being included within the announcement when using the default template.
> This set of supported issue types can be limiting with a modern JIRA installation as is it has a greater range of issue types and can be extended with additional types. The most flexible solution for JIRA and other IMSes would be to allow the the mapping of issue types to action types.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MCHANGES-245) Custom mapping of IMS
issue types to action types for announcements
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=269595#action_269595 ]
Benson Margulies edited comment on MCHANGES-245 at 6/5/11 11:08 AM:
--------------------------------------------------------------------
r1131497 | bimargulies | 2011-06-04 17:59:16 -0400 (Sat, 04 Jun 2011) | 1 line
[MCHANGES-245]: fix stale @since from patch
was (Author: bmargulies):
Also rev r1131497.
> Custom mapping of IMS issue types to action types for announcements
> -------------------------------------------------------------------
>
> Key: MCHANGES-245
> URL: http://jira.codehaus.org/browse/MCHANGES-245
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Affects Versions: 2.4
> Reporter: Alan Parkinson
> Assignee: Benson Margulies
> Fix For: 2.6
>
> Attachments: MCHANGES-245-maven-changes-plugin.patch
>
>
> The current version only maps "Bug", "New Feature" and "Improvement" issues types to "fix", "add" and "update" actions. If the issue type from the IMS isn't recognized the default action type is blank and this leads to the issue not being included within the announcement when using the default template.
> This set of supported issue types can be limiting with a modern JIRA installation as is it has a greater range of issue types and can be extended with additional types. The most flexible solution for JIRA and other IMSes would be to allow the the mapping of issue types to action types.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (MCHANGES-245) Custom mapping of IMS issue types
to action types for announcements
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHANGES-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies reopened MCHANGES-245:
---------------------------------------
Assignee: Benson Margulies
Dennis asks me to make the modularity better.
> Custom mapping of IMS issue types to action types for announcements
> -------------------------------------------------------------------
>
> Key: MCHANGES-245
> URL: http://jira.codehaus.org/browse/MCHANGES-245
> Project: Maven 2.x Changes Plugin
> Issue Type: New Feature
> Components: announcement
> Affects Versions: 2.4
> Reporter: Alan Parkinson
> Assignee: Benson Margulies
> Fix For: 2.6
>
> Attachments: MCHANGES-245-maven-changes-plugin.patch
>
>
> The current version only maps "Bug", "New Feature" and "Improvement" issues types to "fix", "add" and "update" actions. If the issue type from the IMS isn't recognized the default action type is blank and this leads to the issue not being included within the announcement when using the default template.
> This set of supported issue types can be limiting with a modern JIRA installation as is it has a greater range of issue types and can be extended with additional types. The most flexible solution for JIRA and other IMSes would be to allow the the mapping of issue types to action types.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira