You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Bayer <no...@github.com> on 2015/06/18 10:54:57 UTC
[jclouds-labs-google] JCLOUDS-936: Switch to LoadingCache for
disk->image (#157)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs-google/pull/157
-- Commit Summary --
* JCLOUDS-936: Switch to LoadingCache for disk->image
-- File Changes --
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceAdapter.java (15)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/config/GoogleComputeEngineServiceContextModule.java (52)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/InstanceToNodeMetadata.java (24)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/Resources.java (15)
A google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/loaders/DiskURIToImage.java (57)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Disk.java (4)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceMockTest.java (20)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/functions/InstanceToNodeMetadataTest.java (22)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/functions/ResourcesMockTest.java (38)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseInstanceTest.java (3)
A google-compute-engine/src/test/resources/disk_get_with_source_image.json (12)
A google-compute-engine/src/test/resources/image_get_for_source_image.json (25)
M google-compute-engine/src/test/resources/instance_get.json (6)
M google-compute-engine/src/test/resources/instance_list.json (6)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/157.patch
https://github.com/jclouds/jclouds-labs-google/pull/157.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/157
Re: [jclouds-labs-google] JCLOUDS-936: Switch to LoadingCache for
disk->image (#157)
Posted by Ignasi Barrera <no...@github.com>.
> +import com.google.common.cache.CacheLoader;
> +import org.jclouds.googlecomputeengine.compute.functions.Resources;
> +import org.jclouds.googlecomputeengine.domain.Disk;
> +import org.jclouds.googlecomputeengine.domain.Image;
> +import org.jclouds.logging.Logger;
> +
> +
> +@Singleton
> +public class DiskURIToImage extends CacheLoader<URI, Image> {
> + @Resource
> + protected Logger logger = Logger.NULL;
> +
> + private final Resources resources;
> +
> + @Inject
> + public DiskURIToImage(Resources resources) {
Remove the public modifier to make it package private.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/157/files#r32712990
Re: [jclouds-labs-google] JCLOUDS-936: Switch to LoadingCache for
disk->image (#157)
Posted by Ignasi Barrera <no...@github.com>.
Just one minor comment. +1!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/157#issuecomment-113091419
Re: [jclouds-labs-google] JCLOUDS-936: Switch to LoadingCache for
disk->image (#157)
Posted by Andrew Bayer <no...@github.com>.
Done.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/157#issuecomment-113092023