[GitHub] [druid] clintropolis commented on pull request #12291: add topn heap optimization when string is dictionary encoded, but not uniquely

[GitBox <gi...@apache.org>]

clintropolis commented on pull request #12291:
URL: https://github.com/apache/druid/pull/12291#issuecomment-1054990097


   >The existing topn tests should provide adequate coverage for this change, but will confirm this with the coverage bot once it runs in travis.
   
   [It looks like I was right:](https://app.travis-ci.com/github/apache/druid/jobs/561537298#L2110)
   
   ```
   Total diff coverage:
    - lines: 100% (24/24)
    - branches: 100% (16/16)
    - functions: 100% (2/2)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org