You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by kf...@collab.net on 2003/10/28 15:32:44 UTC
Re: [PATCH] minor api change
"Russell Yanofsky" <re...@columbia.edu> writes:
> Log Message:
>
> Minor api change to allow the libsvn_subr library to be built as a dll.
>
> * subversion/include/svn_md5.h
> * libsvn_subr/md5.c
> (svn_md5_empty_string_digest):
> convert this from an extern global into a function that can be
> exported by extractor.py
>
> * subversion/libsvn_fs/reps-strings.c
> (svn_fs__get_mutable_rep, rep_contents_clear):
> update references to svn_md5_empty_string_digest
Pardon my ignorance, but what is the cause of the problem?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] minor api change
Posted by Russell Yanofsky <re...@columbia.edu>.
C. Michael Pilato wrote:
> "Russell Yanofsky" <re...@columbia.edu> writes:
>
>> This is the only place in the subversion api where a global variable
>> is exported from a library. Windows DLLs don't support exported data
>> very well (they require users to prefix declarations with
>> __declspec(dllimport)).
>
> Can't we just use the APR equivalents of those declarations?
The APR macros can only be used for the APR library. We could add our own
system of macros for each subversion library, but we decided against doing
that in this thread:
http://www.contactor.se/~dast/svn/archive-2003-03/1457.shtml
- Russ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] minor api change
Posted by "C. Michael Pilato" <cm...@collab.net>.
"Russell Yanofsky" <re...@columbia.edu> writes:
> This is the only place in the subversion api where a global variable is
> exported from a library. Windows DLLs don't support exported data very well
> (they require users to prefix declarations with
> __declspec(dllimport)).
Can't we just use the APR equivalents of those declarations?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] minor api change
Posted by Russell Yanofsky <re...@columbia.edu>.
kfogel@collab.net wrote:
> "Russell Yanofsky" <re...@columbia.edu> writes:
>> Log Message:
>>
>> Minor api change to allow the libsvn_subr library to be built as a
>> dll.
>>
>> * subversion/include/svn_md5.h
>> * libsvn_subr/md5.c
>> (svn_md5_empty_string_digest):
>> convert this from an extern global into a function that can be
>> exported by extractor.py
>>
>> * subversion/libsvn_fs/reps-strings.c
>> (svn_fs__get_mutable_rep, rep_contents_clear):
>> update references to svn_md5_empty_string_digest
>
> Pardon my ignorance, but what is the cause of the problem?
This is the only place in the subversion api where a global variable is
exported from a library. Windows DLLs don't support exported data very well
(they require users to prefix declarations with __declspec(dllimport)).
- Russ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org