You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2013/11/02 19:05:19 UTC

[jira] [Updated] (THRIFT-1815) Code generators line buffer output

     [ https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1815:
-------------------------------

    Attachment: THRIFT-1815-endl-patch-for-go.patch

> Code generators line buffer output
> ----------------------------------
>
>                 Key: THRIFT-1815
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1815
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (General)
>    Affects Versions: 0.9
>            Reporter: Andrew Gaul
>              Labels: performance
>             Fix For: 0.9.1
>
>         Attachments: THRIFT-1815-endl-patch-for-go.patch, thrift-1815-compiler-line-buffering.patch
>
>
> This results in slow performance on FUSE- and network-based filesystems, e.g., eCryptfs.  std::ostream << std::endl emits a newline and flushes buffers to the kernel[1], yielding excessive system calls.  Instead, emit "\n" which does the equivalent without the flush[2].  The attached patch accomplishes this while minimizing code churn by removing "using namespace std" and introducing a static variable endl.
> [1] http://www.cplusplus.com/reference/ios/endl/
> [2] http://stackoverflow.com/questions/5492380/what-is-the-c-iostream-endl-fiasco



--
This message was sent by Atlassian JIRA
(v6.1#6144)