[GitHub] [bookkeeper] tisonkun commented on a diff in pull request #3451: bugfix for project's .asf.yaml

[GitBox <gi...@apache.org>]

tisonkun commented on code in PR #3451:
URL: https://github.com/apache/bookkeeper/pull/3451#discussion_r950661059


##########
.asf.yaml:
##########
@@ -63,7 +63,7 @@ github:
       required_pull_request_reviews:
         dismiss_stale_reviews: false
         require_code_owner_reviews: true
-        required_approving_review_count: 1
+        required_approving_review_count: 2

Review Comment:
   Basically, I'd prefer not to set it as a strict rule since a committer should be confident to merge a typo fix. Committers share a high trust level. They know when to request one more reviewer.



##########
.asf.yaml:
##########
@@ -63,7 +63,7 @@ github:
       required_pull_request_reviews:
         dismiss_stale_reviews: false
         require_code_owner_reviews: true
-        required_approving_review_count: 1
+        required_approving_review_count: 2

Review Comment:
   Basically, I'd prefer not to set it as a strict rule since a committer should be confident to merge a typo fix directly. Committers share a high trust level. They know when to request one more reviewer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org