You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kibble.apache.org by GitBox <gi...@apache.org> on 2020/10/21 20:41:54 UTC

[GitHub] [kibble] michalslowikowski00 opened a new pull request #66: Add Black to pre-commit

michalslowikowski00 opened a new pull request #66:
URL: https://github.com/apache/kibble/pull/66


   Hi folks.
   This commit will add Black to pre-commit. 
   With Black we will keep our repository clean and beautifully formatted.
   If you don't know Black -- please take a look [here](https://github.com/psf/black).
   
   You can also install Black as a tool in your IDE (Pycharm for example).
   [Black in Pycharm](https://black.readthedocs.io/en/stable/editor_integration.html#pycharm-intellij-idea)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kibble] turbaszek commented on pull request #66: Add Black to pre-commit

Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #66:
URL: https://github.com/apache/kibble/pull/66#issuecomment-716042313


   @michalslowikowski00 some files seem to be not formatted yet


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kibble] turbaszek commented on pull request #66: Add Black to pre-commit

Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #66:
URL: https://github.com/apache/kibble/pull/66#issuecomment-714346810


   @michalslowikowski00 we need to run `pre-commit run --all-files` otherwise CI will be sad :<


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kibble] turbaszek commented on pull request #66: Add Black to pre-commit

Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #66:
URL: https://github.com/apache/kibble/pull/66#issuecomment-714575890


   @michalslowikowski00 would you mind rebasing? I merged #61


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kibble] turbaszek merged pull request #66: Add Black to pre-commit

Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #66:
URL: https://github.com/apache/kibble/pull/66


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kibble] michalslowikowski00 commented on pull request #66: Add Black to pre-commit

Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on pull request #66:
URL: https://github.com/apache/kibble/pull/66#issuecomment-715914156


   Rebased, waiting with merge for Tomek's PR [67](https://github.com/apache/kibble/pull/67)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org