[GitHub] [spark] HyukjinKwon commented on a change in pull request #28058: [SPARK-31290][R] Add back the deprecated R APIs

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #28058: [SPARK-31290][R] Add back the deprecated R APIs
URL: https://github.com/apache/spark/pull/28058#discussion_r399744816
 
 

 ##########
 File path: R/pkg/R/DataFrame.R
 ##########
 @@ -946,6 +973,17 @@ setMethod("write.parquet",
             invisible(handledCallJMethod(write, "parquet", path))
           })
 
+#' @rdname write.parquet
+#' @name saveAsParquetFile
+#' @aliases saveAsParquetFile,SparkDataFrame,character-method
+#' @note saveAsParquetFile since 1.4.0
+setMethod("saveAsParquetFile",
 
 Review comment:
   Okay, using the rubric we added, in R or PySpark, it's very easy to keep the compatibility - if-else based on version and redirect to the alternative. There seems direct alternative too.
   
   Seems like we haven't seen a lot of complaints when we remove `saveAsParquetFile` at  SPARK-12600. I skimmed user-mailing list with keyword search, and I found 0 complaints.
   
   Having write API in `DataFrame` seems inconsistent with Scala and PySpark sides, and also namespace used in R side (e.g., `write.json`) - it causes a cognitive cost.
   
   Shall we remove these one out?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org