You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Blake Sullivan (JIRA)" <de...@myfaces.apache.org> on 2011/01/19 01:55:44 UTC

[jira] Created: (TRINIDAD-2011) RowKeySet Attribute Changes surprisingly change object identity

RowKeySet Attribute Changes surprisingly change object identity
---------------------------------------------------------------

                 Key: TRINIDAD-2011
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2011
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Components
    Affects Versions: 2.0.0-alpha-2, 2.0.0-alpha, 1.2.14-core , 1.2.13-core 
            Reporter: Blake Sullivan


Whenever the ChangeManager restores a RowKeySet, it changes the identity of the underlying object.  This surprises application developers who may have held onto the original instance in order to mutate it and results in the wrong objects being used by the application in many cases.  The solution is to preserve the object identity in all cases by reusing the existing RowKeySet and simply clearing it and then adding the new values.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TRINIDAD-2011) RowKeySet Attribute Changes surprisingly change object identity

Posted by "Blake Sullivan (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989526#comment-12989526 ] 

Blake Sullivan commented on TRINIDAD-2011:
------------------------------------------

Resolved in 1.2.12.3.4 revision 1066337


> RowKeySet Attribute Changes surprisingly change object identity
> ---------------------------------------------------------------
>
>                 Key: TRINIDAD-2011
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2011
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.13-core , 1.2.14-core , 2.0.0-alpha, 2.0.0-alpha-2
>            Reporter: Blake Sullivan
>            Assignee: Blake Sullivan
>             Fix For: 2.0.0-beta-1
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Whenever the ChangeManager restores a RowKeySet, it changes the identity of the underlying object.  This surprises application developers who may have held onto the original instance in order to mutate it and results in the wrong objects being used by the application in many cases.  The solution is to preserve the object identity in all cases by reusing the existing RowKeySet and simply clearing it and then adding the new values.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (TRINIDAD-2011) RowKeySet Attribute Changes surprisingly change object identity

Posted by "Blake Sullivan (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blake Sullivan resolved TRINIDAD-2011.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0-beta-1

Resolved in 2.0 in revision 1060640

> RowKeySet Attribute Changes surprisingly change object identity
> ---------------------------------------------------------------
>
>                 Key: TRINIDAD-2011
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2011
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.13-core , 1.2.14-core , 2.0.0-alpha, 2.0.0-alpha-2
>            Reporter: Blake Sullivan
>            Assignee: Blake Sullivan
>             Fix For: 2.0.0-beta-1
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Whenever the ChangeManager restores a RowKeySet, it changes the identity of the underlying object.  This surprises application developers who may have held onto the original instance in order to mutate it and results in the wrong objects being used by the application in many cases.  The solution is to preserve the object identity in all cases by reusing the existing RowKeySet and simply clearing it and then adding the new values.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TRINIDAD-2011) RowKeySet Attribute Changes surprisingly change object identity

Posted by "Blake Sullivan (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986621#action_12986621 ] 

Blake Sullivan commented on TRINIDAD-2011:
------------------------------------------

Fixed in Trinidad 1.2.x in revision 1063408


> RowKeySet Attribute Changes surprisingly change object identity
> ---------------------------------------------------------------
>
>                 Key: TRINIDAD-2011
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2011
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.13-core , 1.2.14-core , 2.0.0-alpha, 2.0.0-alpha-2
>            Reporter: Blake Sullivan
>            Assignee: Blake Sullivan
>             Fix For: 2.0.0-beta-1
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Whenever the ChangeManager restores a RowKeySet, it changes the identity of the underlying object.  This surprises application developers who may have held onto the original instance in order to mutate it and results in the wrong objects being used by the application in many cases.  The solution is to preserve the object identity in all cases by reusing the existing RowKeySet and simply clearing it and then adding the new values.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TRINIDAD-2011) RowKeySet Attribute Changes surprisingly change object identity

Posted by "Blake Sullivan (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986606#action_12986606 ] 

Blake Sullivan commented on TRINIDAD-2011:
------------------------------------------

Resolved in 1.2.12.3.3 revision 1063403 

> RowKeySet Attribute Changes surprisingly change object identity
> ---------------------------------------------------------------
>
>                 Key: TRINIDAD-2011
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2011
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.13-core , 1.2.14-core , 2.0.0-alpha, 2.0.0-alpha-2
>            Reporter: Blake Sullivan
>            Assignee: Blake Sullivan
>             Fix For: 2.0.0-beta-1
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Whenever the ChangeManager restores a RowKeySet, it changes the identity of the underlying object.  This surprises application developers who may have held onto the original instance in order to mutate it and results in the wrong objects being used by the application in many cases.  The solution is to preserve the object identity in all cases by reusing the existing RowKeySet and simply clearing it and then adding the new values.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.