[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

[SolidWallOfCode <gi...@git.apache.org>]

Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/653#discussion_r65651692
  
    --- Diff: iocore/hostdb/HostDB.cc ---
    @@ -439,37 +327,24 @@ HostDBCache::start(int flags)
         Warning("Please set 'proxy.config.hostdb.storage_path' or 'proxy.config.local_state_dir'");
       }
     
    -  hostDBStore = new Store;
    -  hostDBSpan = new Span;
    -  hostDBSpan->init(storage_path, storage_size);
    -  hostDBStore->add(hostDBSpan);
    -
    -  Debug("hostdb", "Opening %s, size=%d", hostdb_filename, hostdb_size);
    -  if (open(hostDBStore, "hostdb.config", hostdb_filename, hostdb_size, reconfigure, fix, false /* slient */) < 0) {
    -    ats_scoped_str rundir(RecConfigReadRuntimeDir());
    -    ats_scoped_str config(Layout::relative_to(rundir, "hostdb.config"));
    +  // Combine the path and name
    +  char full_path[2 * PATH_NAME_MAX];
    --- End diff --
    
    Presumably if you really need more than `PATH_NAME_MAX` it's not going to work anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---