You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "XComp (via GitHub)" <gi...@apache.org> on 2023/05/08 12:30:19 UTC
[GitHub] [flink] XComp opened a new pull request, #22544: [FLINK-32029][core] Adds fallback error handling to FutureUtils.handleUncaughtException
XComp opened a new pull request, #22544:
URL: https://github.com/apache/flink/pull/22544
## What is the purpose of the change
I ran into an issue in FLINK-31773 where a `NullPointerException` was thrown by the error handling code (because the contender wasn't set, anymore). That one went unnoticed the the corresponding unit tests because we don't handle errors in the error handling code. This PR adds this code path.
## Brief change log
* Migrates `FutureUtilsTest` from JUnit4/Hamcrest to JUnit5/AssertJ (separate commit)
* Adds fallback error handling to `FutureUtils.handleUncaughtException`
## Verifying this change
* a helper method was added that allows configuring the fallback exception handler
* a test was added covering the scenario
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #22544: [FLINK-32029][core] Adds fallback error handling to FutureUtils.handleUncaughtException
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #22544:
URL: https://github.com/apache/flink/pull/22544#discussion_r1188199532
##########
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/executor/TestExecutorExtension.java:
##########
@@ -49,6 +58,20 @@ public T getExecutor() {
public void afterAll(ExtensionContext context) throws Exception {
if (executorService != null) {
executorService.shutdown();
+
+ try {
Review Comment:
No, this change is not related. I was too lazy to create a Jira issue for that one and just added it as a minor hotfix commit. But you're right. It's too different to let it slip through. :-) I created FLINK-32039 to cover it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp merged pull request #22544: [FLINK-32029][core] Adds fallback error handling to FutureUtils.handleUncaughtException
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp merged PR #22544:
URL: https://github.com/apache/flink/pull/22544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pgaref commented on a diff in pull request #22544: [FLINK-32029][core] Adds fallback error handling to FutureUtils.handleUncaughtException
Posted by "pgaref (via GitHub)" <gi...@apache.org>.
pgaref commented on code in PR #22544:
URL: https://github.com/apache/flink/pull/22544#discussion_r1188052161
##########
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/executor/TestExecutorExtension.java:
##########
@@ -49,6 +58,20 @@ public T getExecutor() {
public void afterAll(ExtensionContext context) throws Exception {
if (executorService != null) {
executorService.shutdown();
+
+ try {
Review Comment:
Is the graceful shutdown change related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #22544: [FLINK-32029][core] Adds fallback error handling to FutureUtils.handleUncaughtException
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #22544:
URL: https://github.com/apache/flink/pull/22544#issuecomment-1539842522
LGTM
Also confirm that without fix test is failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pgaref commented on a diff in pull request #22544: [FLINK-32029][core] Adds fallback error handling to FutureUtils.handleUncaughtException
Posted by "pgaref (via GitHub)" <gi...@apache.org>.
pgaref commented on code in PR #22544:
URL: https://github.com/apache/flink/pull/22544#discussion_r1188052161
##########
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/executor/TestExecutorExtension.java:
##########
@@ -49,6 +58,20 @@ public T getExecutor() {
public void afterAll(ExtensionContext context) throws Exception {
if (executorService != null) {
executorService.shutdown();
+
+ try {
Review Comment:
Is this change related?
##########
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/executor/TestExecutorResource.java:
##########
@@ -47,6 +55,20 @@ public T getExecutor() {
protected void after() {
if (executorService != null) {
executorService.shutdown();
+
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #22544: [FLINK-32029][core] Adds fallback error handling to FutureUtils.handleUncaughtException
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #22544:
URL: https://github.com/apache/flink/pull/22544#issuecomment-1539552187
I dropped the Executor shutdown commit (this one is moved to FLINK-32039) and rebased the branch. Thanks for your review, @pgaref
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22544: [FLINK-32029][core] Adds fallback error handling to FutureUtils.handleUncaughtException
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22544:
URL: https://github.com/apache/flink/pull/22544#issuecomment-1538286238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9ba59ac5c9167740d640f97723c269535811b229",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9ba59ac5c9167740d640f97723c269535811b229",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9ba59ac5c9167740d640f97723c269535811b229 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #22544: [FLINK-32029][core] Adds fallback error handling to FutureUtils.handleUncaughtException
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #22544:
URL: https://github.com/apache/flink/pull/22544#discussion_r1188199816
##########
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/executor/TestExecutorResource.java:
##########
@@ -47,6 +55,20 @@ public T getExecutor() {
protected void after() {
if (executorService != null) {
executorService.shutdown();
+
Review Comment:
See [my comment above](https://github.com/apache/flink/pull/22544#discussion_r1188199532)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org