[GitHub] [airflow] potiuk commented on a change in pull request #11474: Adds dependencies between test jobs to avoid cancel starvation

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #11474:
URL: https://github.com/apache/airflow/pull/11474#discussion_r503398005



##########
File path: .github/workflows/ci.yml
##########
@@ -363,7 +363,7 @@ jobs:
     timeout-minutes: 60
     name: "${{matrix.test-type}}:MySQL${{matrix.mysql-version}}, Py${{matrix.python-version}}"
     runs-on: ubuntu-latest
-    needs: [build-info, ci-images]
+    needs: [build-info, ci-images, tests-postgres]

Review comment:
       Correct. They will run in "per-db" "batches" .  It's not as bad as it seems @dimberman - they will slow down an individual PR if the queue is empty (I think we have up to 100-150 slots in our Queue, not sure exactly). But when there are like 10 PRs (as we currently have) competing for the queue and for example one of them fails in the "static check" phase, there is much higher chance that a new PR or one of those waiting will run "cancel" job much faster and free the queue, which will make the "good" PRs complete faster.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org