You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/07/17 23:30:16 UTC
Re: Review Request 60235: Linted support/test-upgrade.py.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60235/#review180765
-----------------------------------------------------------
support/test-upgrade.py
Lines 114-115 (original), 142-147 (patched)
<https://reviews.apache.org/r/60235/#comment255990>
This refactoring doesn't retain the original logic.
The script does the following:
1) Launch the Master/Agent/Framework of version A.
2) Kill Agent A, kill Master A, start Master B, start Agent A, start Framework A. The agent is only restarted here due to how the StandaloneMasterDetector is implemented.
3) Kill Agent A, start Agent B, start Framework A.
4) Start Framework B.
This refactoring will cause the master to be killed twice more than the original and the agent to be killed once more.
I think it would be fine to make 4 new methods for each of the test steps (start_cluster, upgrade_master, upgrade_agent, upgrade_framework).
- Joseph Wu
On June 26, 2017, 8:48 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60235/
> -----------------------------------------------------------
>
> (Updated June 26, 2017, 8:48 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joseph Wu.
>
>
> Bugs: MESOS-6390
> https://issues.apache.org/jira/browse/MESOS-6390
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This will allow us to use PyLint on the
> entire support directory in the future.
>
>
> Diffs
> -----
>
> support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
>
>
> Diff: https://reviews.apache.org/r/60235/diff/2/
>
>
> Testing
> -------
>
> Added `support` to `source_dirs` in the PyLinter defined
> in `mesos-style.py`. Linted until only acceptable errors
> where displayed (e.g. due to the name of the file containing
> a dash instead of an underscore).
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 60235: Linted support/test-upgrade.py.
Posted by Armand Grillet <ag...@mesosphere.io>.
> On July 17, 2017, 11:30 p.m., Joseph Wu wrote:
> > support/test-upgrade.py
> > Lines 114-115 (original), 142-147 (patched)
> > <https://reviews.apache.org/r/60235/diff/2/?file=1762905#file1762905line156>
> >
> > This refactoring doesn't retain the original logic.
> >
> > The script does the following:
> >
> > 1) Launch the Master/Agent/Framework of version A.
> > 2) Kill Agent A, kill Master A, start Master B, start Agent A, start Framework A. The agent is only restarted here due to how the StandaloneMasterDetector is implemented.
> > 3) Kill Agent A, start Agent B, start Framework A.
> > 4) Start Framework B.
> >
> > This refactoring will cause the master to be killed twice more than the original and the agent to be killed once more.
> >
> > I think it would be fine to make 4 new methods for each of the test steps (start_cluster, upgrade_master, upgrade_agent, upgrade_framework).
I should have documented the change, this is the result of a discussion with Benjamin about the fact that these are not test cases if they are not independent. As it is not linting anymore I am thinking abour renaming the review request "Refactored support/test-upgrade.py.", would you rather suggest a linting in that review request with an other one doing the change in the logic?
- Armand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60235/#review180765
-----------------------------------------------------------
On June 26, 2017, 3:48 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60235/
> -----------------------------------------------------------
>
> (Updated June 26, 2017, 3:48 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joseph Wu.
>
>
> Bugs: MESOS-6390
> https://issues.apache.org/jira/browse/MESOS-6390
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This will allow us to use PyLint on the
> entire support directory in the future.
>
>
> Diffs
> -----
>
> support/test-upgrade.py 84df21dd6e63653e1a18e700ef904aa3a04b2b45
>
>
> Diff: https://reviews.apache.org/r/60235/diff/2/
>
>
> Testing
> -------
>
> Added `support` to `source_dirs` in the PyLinter defined
> in `mesos-style.py`. Linted until only acceptable errors
> where displayed (e.g. due to the name of the file containing
> a dash instead of an underscore).
>
>
> Thanks,
>
> Armand Grillet
>
>