You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martijn Dashorst <ma...@gmail.com> on 2007/06/26 00:31:20 UTC

[vote] release Apache Wicket 1.3.0-incubating-beta-2

This is a vote to release the Apache Wicket 1.3.0-beta2 (note the
missing -incubating) distribution I just uploaded to my
people.apache.org account page.

I know we are anxious to get this one out the door, but I urge all of
us to go through the release and check if you find anything wrong with
it, and/or license wise wrongs. Particular care needs to be applied to
the new projects wicket-ioc and wicket-guice.

[ ] I checked the distribution, and I +1 the release of them
[ ] I didn't check the distribution, but I want to release them regardless (+0)
[ ] I don't want to release the distribution, because ...

You can find the RAT log, distributions and maven repository here:

http://people.apache.org/~dashorst/releases/apache-wicket-1.3.0-beta2

Standard release procedures apply: 72 hours, at minimum 3 +1's from PMC members.

Martijn

Re: [vote] release Apache Wicket 1.3.0-incubating-beta-2

Posted by Janne Hietamäki <ja...@apache.org>.
What the situation with wicket.util.concurrent? Can we remove this  
comment from ApacheLicenceHeaderTest, since there is a comment in the  
NOTICE file.
.
                                 /*
                                  * Needs to be resolved (rewritten  
or NOTICE)
                                  */
                                 "src/main/java/org/apache/wicket/ 
util/concurrent/ConcurrentReaderHashMap.java",
                                 "src/main/java/org/apache/wicket/ 
util/concurrent/ConcurrentHashMap.java",
                                 "src/main/java/org/apache/wicket/ 
util/concurrent/CopyOnWriteArrayList.java"

On 26.6.2007, at 1.31, Martijn Dashorst wrote:

> [x] I checked the distribution, and I +1 the release of them
> [ ] I didn't check the distribution, but I want to release them  
> regardless (+0)
> [ ] I don't want to release the distribution, because ...
>

Janne


Re: [vote] release Apache Wicket 1.3.0-incubating-beta-2

Posted by Martijn Dashorst <ma...@gmail.com>.
On 6/26/07, Frank Bille <fr...@gmail.com> wrote:
> On 6/26/07, Martijn Dashorst <ma...@gmail.com> wrote:
> > Because it is 1.1 ... Apache doesn't ship 1.1 (prohibits it).
> But what does this mean to us? If we are allowed to ship ASL2 code which
> includes ASL1.1 code aRat should at least mark the files as ASL1 or
> something.

I think it doesn't mean anything. The code is copied from codehaus,
not Apache. Therefore we have to abide to their licensing. If that is
Apache 1.1, then so be it.

The only other option is to replace the code.

Martijn

-- 
Wicket joins the Apache Software Foundation as Apache Wicket
Join the wicket community at irc.freenode.net: ##wicket
Wicket 1.2.6 contains a very important fix. Download Wicket now!
http://wicketframework.org

Re: [vote] release Apache Wicket 1.3.0-incubating-beta-2

Posted by Frank Bille <fr...@gmail.com>.
On 6/26/07, Martijn Dashorst <ma...@gmail.com> wrote:
>
> Because it is 1.1 ... Apache doesn't ship 1.1 (prohibits it).
>

But what does this mean to us? If we are allowed to ship ASL2 code which
includes ASL1.1 code aRat should at least mark the files as ASL1 or
something.

Frank

/me thinks it's a bug in the rat tool.

Re: [vote] release Apache Wicket 1.3.0-incubating-beta-2

Posted by Martijn Dashorst <ma...@gmail.com>.
Because it is 1.1 ... Apache doesn't ship 1.1 (prohibits it).

Martijn

On 6/26/07, Johan Compagner <jc...@gmail.com> wrote:
> [X ] I checked the distribution, and I +1 the release of them
>
> why doesn't RAT like the Diff package?
> it is ASL (not 2.0 but 1.1)
>
> johan
>
>
> On 6/26/07, Martijn Dashorst <ma...@gmail.com> wrote:
> >
> > This is a vote to release the Apache Wicket 1.3.0-beta2 (note the
> > missing -incubating) distribution I just uploaded to my
> > people.apache.org account page.
> >
> > I know we are anxious to get this one out the door, but I urge all of
> > us to go through the release and check if you find anything wrong with
> > it, and/or license wise wrongs. Particular care needs to be applied to
> > the new projects wicket-ioc and wicket-guice.
> >
> >
> > [ ] I didn't check the distribution, but I want to release them regardless
> > (+0)
> > [ ] I don't want to release the distribution, because ...
> >
> > You can find the RAT log, distributions and maven repository here:
> >
> > http://people.apache.org/~dashorst/releases/apache-wicket-1.3.0-beta2
> >
> > Standard release procedures apply: 72 hours, at minimum 3 +1's from PMC
> > members.
> >
> > Martijn
> >
>


-- 
Wicket joins the Apache Software Foundation as Apache Wicket
Join the wicket community at irc.freenode.net: ##wicket
Wicket 1.2.6 contains a very important fix. Download Wicket now!
http://wicketframework.org

Re: [vote] release Apache Wicket 1.3.0-incubating-beta-2

Posted by Johan Compagner <jc...@gmail.com>.
[X ] I checked the distribution, and I +1 the release of them

why doesn't RAT like the Diff package?
it is ASL (not 2.0 but 1.1)

johan


On 6/26/07, Martijn Dashorst <ma...@gmail.com> wrote:
>
> This is a vote to release the Apache Wicket 1.3.0-beta2 (note the
> missing -incubating) distribution I just uploaded to my
> people.apache.org account page.
>
> I know we are anxious to get this one out the door, but I urge all of
> us to go through the release and check if you find anything wrong with
> it, and/or license wise wrongs. Particular care needs to be applied to
> the new projects wicket-ioc and wicket-guice.
>
>
> [ ] I didn't check the distribution, but I want to release them regardless
> (+0)
> [ ] I don't want to release the distribution, because ...
>
> You can find the RAT log, distributions and maven repository here:
>
> http://people.apache.org/~dashorst/releases/apache-wicket-1.3.0-beta2
>
> Standard release procedures apply: 72 hours, at minimum 3 +1's from PMC
> members.
>
> Martijn
>

Re: [vote] release Apache Wicket 1.3.0-incubating-beta-2

Posted by Martijn Dashorst <ma...@gmail.com>.
Release notes:


Release Notes - Wicket - Version 1.3.0-beta2


** Bug
    * [WICKET-4] - Page.onBeginRequest() [and consequently
.onAttach()] not called when form on page is submitted.
    * [WICKET-40] - Parameters of nice URL's pages with 'sensitive' characters
    * [WICKET-65] - Handle String array in PageParameters
    * [WICKET-139] - DefaultTreeState allowSelectMultiple == false not
evaluated when selecting node already selected
    * [WICKET-175] - Page.onDetach is called by each
ComponentResourceRequestTarget
    * [WICKET-254] - Allow to set field values before submitting a
form with Ajax in WicketTester
    * [WICKET-293] - PackageRequestTargetUrlCodingStrategy should
interrupts the cycle and sends a 404 when a page/class cannot be
found.
    * [WICKET-319] - No java source code in examples
    * [WICKET-323] - AjaxEditableLabel on setModel does not update the
labels model only the editors
    * [WICKET-341] - [Patch] AjaxServerAndClientTimeFilter either
throws an exception or displays a wrong text
    * [WICKET-370] - wicket.jmx.Application.getHomePageClass() returns
Application's class name
    * [WICKET-373] - Some components miss localization (NavigatorLabel, Palette)
    * [WICKET-377] - Editing an AjaxEditableLabel, going to a new
page, clicking the back button and editing the label again makes the
page expire.
    * [WICKET-405] - StatelessForm and setRedirect(true) in the onSubmit method
    * [WICKET-409] - Page constructed twice when a BookmarkableLink
has PopupSettings
    * [WICKET-444] - src attribute path not processed by wicket for
INPUT type=image and any IMG with wicket:message in it
    * [WICKET-455] - mvn jetty:run; maven-jetty-plugin not configured
    * [WICKET-464] - Add global override to disable gzip compression
(SAP double-compresses).
    * [WICKET-478] - WicketTester.clickLink() does not recognize SubmitLink.
    * [WICKET-501] - JavaScript comment stripping doesn't handle regexps
    * [WICKET-504] - Allow to use <button> in AjaxSubmitLink
    * [WICKET-513] - Example "pub" doesn't work any more. The images
are no longer localized
    * [WICKET-514] - authorization and authentication examples throw exceptions
    * [WICKET-526] - URL mounting doesn't work well together with
stateless pages
    * [WICKET-557] - RedirectPage inside ListView causes page expiration issues
    * [WICKET-558] - New attach->beforeRender refactor breaks ajax
updating of list views
    * [WICKET-565] - parent poms missing in 1.3.0-beta1
    * [WICKET-566] - <scope>tests</scope> should be <scope>test</scope>
    * [WICKET-567] - relative paths generated incorrectly for
HeaderContributor for mounted page
    * [WICKET-568] - Form url handled wrong when using
QueryStringUrlCodingStrategy
    * [WICKET-576] - PopupSettings with no window name set generates
invalid xhtml on Link
    * [WICKET-578] - AbstractTextComponent is using onAttach when it
should be onBeforeRender
    * [WICKET-583] - Header Contribution in ModalWindow doesn't work properly
    * [WICKET-586] - Quickstart web.xml
    * [WICKET-589] - problem with Ajax and rendering
    * [WICKET-590] - RelativePathPrefixHandler and
WicketMessageTagHandler conflict
    * [WICKET-591] - SignInPanel is not returning raw input
    * [WICKET-593] - equals() in ResourceStreamRequestTarget compares
the wrong filename
    * [WICKET-595] - TimeOfDay.next(Calendar) can return time on same
day rather than next day
    * [WICKET-600] - getClientInfo throws ClassCastException when
Javascript is Disabled
    * [WICKET-603] - Injecting a reference to a bean which is of a
final class fails
    * [WICKET-606] -
AbstractTextComponent#setConvertEmptyInputStringToNull(true) does not
work with IObjectClassAwareModels (affects TextField, etc.)
    * [WICKET-610] - header contributions fail on <error-pages>
    * [WICKET-612] - HeaderContributor forces relative URL
    * [WICKET-613] - Prototype scoped Spring beans
    * [WICKET-615] - BookmarkablePageRequestTarget respond method
    * [WICKET-621] - detach() is not called when nested object is
IDetachable but not IModel in CompoundPropertyModel
    * [WICKET-624] - AbstractSingleChoice: components can't have
specific null or nullValid messages
    * [WICKET-628] - WicketFilter tries to call setClassLoader() even
if it's not changing the default - doesn't work on strict
SecurityManagers.
    * [WICKET-629] - NPE when using DatePicker with DateTextField
    * [WICKET-644] - SpringWebApplicationFactory references wrong
package in javadoc.
    * [WICKET-659] - Null form fields are converted to empty strings
    * [WICKET-667] - [PATCH] remove XX in firefox and palette
    * [WICKET-673] - synchronize AbstractBehavior#isEnabled(Component
component) with Component#isEnabled
    * [WICKET-684] - JavaScript complains if an AjaxButton has the name "submit"
    * [WICKET-687] - DatePicker refers to gif files on Yahoo
    * [WICKET-688] - DatePicker doesn't work with TextField

** Improvement
    * [WICKET-6] - Configuration of app mode isn't customisable
    * [WICKET-49] - Upgrade all war-type projects (examples,
quickstart) to use jetty 6 and jetty-maven-plugin
    * [WICKET-301] - Translation for Czech language
    * [WICKET-344] - clock component doesn't display seconds in some Locales
    * [WICKET-348] - Propose removing 'final' modifier to
AbstractSingleSelectChoice.convertValue()
    * [WICKET-362] - Add ability to manage disabled items from
subclasses of AbstractChoice
    * [WICKET-388] - Change log statement in Objects#setObjectStreamFactory()
    * [WICKET-394] - [Patch] do not serialize choices and select in palette.
    * [WICKET-416] - Handle / servlet mapping or fail consistenly
    * [WICKET-481] - Take into account the button and input tags in
AbstractLink#disableLink()
    * [WICKET-531] - FormComponentLabel and Radio
    * [WICKET-549] - HeaderContributions are missing if <html> is a Component.
    * [WICKET-556] - Prevent setTimeout for
AjaxSelfUpdatingTimerBehavior from firing after its contributing
component has been replaced
    * [WICKET-561] - TextField should determine the object type from
the model if the model supports it
    * [WICKET-577] - Improve TabbedPanel component - add ability to
change tab-row container
    * [WICKET-582] - Enhancement of exception message in
WebExternalResourceStream
    * [WICKET-587] - Entity references in DTD are missing the path to w3.com
    * [WICKET-614] - Markup ids from markup should be honored for CSS
reasons, even with outputMarkupId == true
    * [WICKET-616] - Provide default CSS for UploadProgressBar
    * [WICKET-619] - Models that can should be able to provide
information about field/getter/setter
    * [WICKET-633] - Tree components cleanup
    * [WICKET-636] - Get the ability to add some properties to the
html "<option>" tag for the palette component
    * [WICKET-637] - wicket-examples grey-on-white colour scheme is
very hard to read
    * [WICKET-638] - wicket-examples source code view is not resizable
    * [WICKET-664] - Allow users to hook into onbeforeunload event so
they can tell when a page is closed in the browser
    * [WICKET-671] - InlineFrame page constructor doesn't behave as expected
    * [WICKET-672] - DateTextField is too session-heavy
    * [WICKET-674] - when setting stripJavascriptCommentsAndWhitespace
is true, also strip comments and whitespace of PackagedTextTemplates
    * [WICKET-689] - Please make it easier to use a custom RequestCycle
    * [WICKET-692] - upgrade YUI dependencies to version 2.2.2 for
wicket-datetime

** New Feature
    * [WICKET-580] - add EmptyPanel class
    * [WICKET-608] - Add possibility to output markup class as html comment
    * [WICKET-630] - It should be possible to specify different CSS
class names for certain columns in DataTable



** Task
    * [WICKET-264] - stockquote app
    * [WICKET-508] - Move TextTemplate to core
    * [WICKET-562] - include SLF4J jar in the Wicket 1.3 zip distribution



** Wish
    * [WICKET-383] - Wicket-Examples war file needs slf4j



-- 
Wicket joins the Apache Software Foundation as Apache Wicket
Join the wicket community at irc.freenode.net: ##wicket
Wicket 1.2.6 contains a very important fix. Download Wicket now!
http://wicketframework.org

Re: [vote] release Apache Wicket 1.3.0-incubating-beta-2

Posted by Frank Bille <fr...@gmail.com>.
On 6/26/07, Martijn Dashorst <ma...@gmail.com> wrote:
>
> [x] I checked the distribution, and I +1 the release of them


Small (non-blocking) thing:

http://svn.apache.org/viewvc/incubator/wicket/releases/wicket-1.3.0-beta2/README?view=co

says

"All necessary dependencies are located in the /lib directory of this
package."

I guess we should delete that.

Frank

Re: [vote] release Apache Wicket 1.3.0-incubating-beta-2

Posted by Igor Vaynberg <ig...@gmail.com>.
On 6/25/07, Martijn Dashorst <ma...@gmail.com> wrote:
>
> [x] I didn't check the distribution, but I want to release them regardless
> (+0)
>
>

Re: [vote] release Apache Wicket 1.3.0-incubating-beta-2

Posted by Eelco Hillenius <ee...@gmail.com>.
 [ ] I checked the distribution, and I +1 the release of them
 [ x ] I didn't check the distribution, but I want to release them
regardless (+0)
 [ ] I don't want to release the distribution, because ...

Eelco

Re: [vote] release Apache Wicket 1.3.0-incubating-beta-2

Posted by Johan Compagner <jc...@gmail.com>.
you are building with java6 wicket 1.2 should be build with java 1.4

but i thought jonathan did fix this that we are now stable again and not
depending on the order of the keys from a hashmap

johan


On 6/28/07, Martin Funk <fu...@arcor.de> wrote:
>
> err...
>
> I get a failing unit test on this one:
>
> https://issues.apache.org/jira/browse/WICKET-708
>
> possibly a java implmentation issue?
>
> http://www.nabble.com/different-jdk-behavior-depending-on-OS-or-version-tf3673677.html#a10265596
>
>
> mf
>

Re: [vote] release Apache Wicket 1.3.0-incubating-beta-2

Posted by Martin Funk <fu...@arcor.de>.
err...

I get a failing unit test on this one:

https://issues.apache.org/jira/browse/WICKET-708

possibly a java implmentation issue?
http://www.nabble.com/different-jdk-behavior-depending-on-OS-or-version-tf3673677.html#a10265596


mf

Re: [vote] release Apache Wicket 1.3.0-incubating-beta-2

Posted by Martijn Dashorst <ma...@gmail.com>.
I found this one on the Apache site [1]:

If A Distribution Contains Code Under Several Licenses, Should It
Contain Several License Files?

No - all license information should be contained in the LICENSE file.

When a distribution contains code under several licenses, the LICENSE
file should contain details of all these licenses. For each component
which is not Apache licensed, details of the component and the license
under which the component is distributed should be appended to the
LICENSE file.

I guess I have to perform some additional license scripting foo.

Martijn

[1] http://www.apache.org/dev/release.html#distributing-code-under-several-licenses

On 6/26/07, Jean-Baptiste Quenot <jb...@apache.org> wrote:
> [ ] I checked the distribution, and I +1 the release of them
> [ ] I didn't check the distribution, but I want to release them regardless (+0)
> [x] I don't want to release the distribution, because wicket-ioc
>     and wicket-guice are not in the "lib" directory, which may prevent
>     wicket-spring from working if someone takes it from there.
>     However the wicket examples war *has* those dependencies so
>     it's not a major issue.
> --
>      Jean-Baptiste Quenot
> aka  John Banana   Qwerty
> http://caraldi.com/jbq/
>


-- 
Wicket joins the Apache Software Foundation as Apache Wicket
Join the wicket community at irc.freenode.net: ##wicket
Wicket 1.2.6 contains a very important fix. Download Wicket now!
http://wicketframework.org

Re: [vote] release Apache Wicket 1.3.0-incubating-beta-2

Posted by Jean-Baptiste Quenot <jb...@apache.org>.
[ ] I checked the distribution, and I +1 the release of them
[ ] I didn't check the distribution, but I want to release them regardless (+0)
[x] I don't want to release the distribution, because wicket-ioc
    and wicket-guice are not in the "lib" directory, which may prevent
    wicket-spring from working if someone takes it from there.
    However the wicket examples war *has* those dependencies so
    it's not a major issue.
-- 
     Jean-Baptiste Quenot
aka  John Banana   Qwerty
http://caraldi.com/jbq/