You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shenyu.apache.org by AhahaGe <ah...@163.com> on 2022/01/04 07:59:00 UTC

A pr review and approve request of Apache dubbo example doc for version 2.4.0 and 2.4.1

Hi Community, 


  I create a pr for apache dubbo example doc version 2.4.0 and 2.4.1.
  I download our tag 2.4.0 and tag 2.4.1 source code and use the doc under user-guide/dubbo-proxy.md to test apache dubbo example.
  After test in my local, I deleted the spring part doc and improved the spring-boot part doc.
  Hope anyone can help review my pr.
  > [1]:  https://github.com/apache/incubator-shenyu-website/pull/425
Many thanks.

Re: Re: A pr review and approve request of Apache dubbo example doc for version 2.4.0 and 2.4.1

Posted by XiaoYu <xi...@apache.org>.
Hi AhahaGe

good job，thanks

AhahaGe <ah...@163.com> 于2022年1月4日周二 16:21写道：
>
> In master, I submited some pr before and dubbo xml is supported in our latest code. Example code PR, https://github.com/apache/incubator-shenyu/pull/2659, and doc PR https://github.com/apache/incubator-shenyu-website/pull/417.
> The new dubbo xml pr's example and doc can't run in tag/v2.4.0 and tag/v2.4.1. And the doc v2.4.1 and v2.4.0 now in our website also can't run. So I suggest we can delete it in v2.4.0 and v2.4.1.
>
> Thanks.
>
>
>
>
>
>
>
>
> 在 2022-01-04 16:03:17，"XiaoYu" <xi...@apache.org> 写道：
> >hi AhahaGe:
> >
> >in 2.4.0 and 2.4.1,dubbo-client can not support XML?   in master can support?
> >
> >thanks~
> >
> >AhahaGe <ah...@163.com> 于2022年1月4日周二 15:59写道：
> >>
> >> Hi Community,
> >>
> >>
> >>   I create a pr for apache dubbo example doc version 2.4.0 and 2.4.1.
> >>   I download our tag 2.4.0 and tag 2.4.1 source code and use the doc under user-guide/dubbo-proxy.md to test apache dubbo example.
> >>   After test in my local, I deleted the spring part doc and improved the spring-boot part doc.
> >>   Hope anyone can help review my pr.
> >>   > [1]:  https://github.com/apache/incubator-shenyu-website/pull/425
> >> Many thanks.
> >>

Re:Re: A pr review and approve request of Apache dubbo example doc for version 2.4.0 and 2.4.1

Posted by AhahaGe <ah...@163.com>.
In master, I submited some pr before and dubbo xml is supported in our latest code. Example code PR, https://github.com/apache/incubator-shenyu/pull/2659, and doc PR https://github.com/apache/incubator-shenyu-website/pull/417. 
The new dubbo xml pr's example and doc can't run in tag/v2.4.0 and tag/v2.4.1. And the doc v2.4.1 and v2.4.0 now in our website also can't run. So I suggest we can delete it in v2.4.0 and v2.4.1.

Thanks.








在 2022-01-04 16:03:17，"XiaoYu" <xi...@apache.org> 写道：
>hi AhahaGe:
>
>in 2.4.0 and 2.4.1,dubbo-client can not support XML?   in master can support?
>
>thanks~
>
>AhahaGe <ah...@163.com> 于2022年1月4日周二 15:59写道：
>>
>> Hi Community,
>>
>>
>>   I create a pr for apache dubbo example doc version 2.4.0 and 2.4.1.
>>   I download our tag 2.4.0 and tag 2.4.1 source code and use the doc under user-guide/dubbo-proxy.md to test apache dubbo example.
>>   After test in my local, I deleted the spring part doc and improved the spring-boot part doc.
>>   Hope anyone can help review my pr.
>>   > [1]:  https://github.com/apache/incubator-shenyu-website/pull/425
>> Many thanks.
>>

Re: A pr review and approve request of Apache dubbo example doc for version 2.4.0 and 2.4.1

Posted by XiaoYu <xi...@apache.org>.
hi AhahaGe:

in 2.4.0 and 2.4.1,dubbo-client can not support XML?   in master can support?

thanks~

AhahaGe <ah...@163.com> 于2022年1月4日周二 15:59写道：
>
> Hi Community,
>
>
>   I create a pr for apache dubbo example doc version 2.4.0 and 2.4.1.
>   I download our tag 2.4.0 and tag 2.4.1 source code and use the doc under user-guide/dubbo-proxy.md to test apache dubbo example.
>   After test in my local, I deleted the spring part doc and improved the spring-boot part doc.
>   Hope anyone can help review my pr.
>   > [1]:  https://github.com/apache/incubator-shenyu-website/pull/425
> Many thanks.
>