[GitHub] [superset] hughhhh commented on a diff in pull request #21248: feat: filter parameters from DB API

[GitBox <gi...@apache.org>]

hughhhh commented on code in PR #21248:
URL: https://github.com/apache/superset/pull/21248#discussion_r958921795


##########
superset/databases/dao.py:
##########
@@ -33,6 +34,25 @@ class DatabaseDAO(BaseDAO):
     model_cls = Database
     base_filter = DatabaseFilter
 
+    @classmethod
+    def update(
+        cls,
+        model: Database,
+        properties: Dict[str, Any],
+        commit: bool = True,
+    ) -> Database:
+        if "encrypted_extra" in properties:
+            new = json.loads(properties["encrypted_extra"])

Review Comment:
   shouldn't we have try/except here just incase we have malformed coming in from the modal?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org