[GitHub] [accumulo] ctubbsii commented on a change in pull request #1985: Move Constraints to API

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1985:
URL: https://github.com/apache/accumulo/pull/1985#discussion_r610769003



##########
File path: core/src/main/java/org/apache/accumulo/core/constraints/Constraint.java
##########
@@ -52,9 +53,20 @@
      * Gets the key extent of the environment.
      *
      * @return key extent
+     * @deprecated since 2.1 use {@link #getTablet()}
      */
+    @Deprecated(since = "2.1.0")

Review comment:
       By deprecating this, it seems the intent is to try to make `org.apache.accumulo.core.constraints` another package in the public API. Rather than add another package to the API, we could instead create a new subpackage in an existing API package (`core.data.constraints`, for example), and start a new interface from scratch there, and deprecate this entire interface. This old interface can extend that one, so any implementation of this deprecated interface would also be an instance of the new interface.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org